Reinstate values for License and Copyright #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and PackageCopyrightText Signed-off-by: Rodney Richardson <[email protected]>
|
What was the reason those attributes were hardcoded to NOASSERTION? While I hope @RodneyRichardson fixes the issue of not having any license data available, I wonder why this was removed and merged into master in the first place. Any maintainer (or anyone else who knows the answer) could clarify that please? |
|
Is this project active any more!? |
|
LGTM |
|
LGTM, any reason why this hasn't been merged? |
|
FYI, The build is failing. |
|
I wish I could see why... it's been so long since this was made the build logs have been deleted! @niravpatel27 : Can you kick off the build again? |
CNugteren
added a commit
to plumerai/spdx-sbom-generator
that referenced
this pull request
Sep 14, 2022
Signed-off-by: Cedric Nugteren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PackageLicenseConcluded, PackageLicenseDeclared, and PackageCopyrightText fields were hardcoded at some point to NOASSERTION (see https://github.com/spdx/spdx-sbom-generator/pull/127/files#diff-768d2ba15583dd4ccee88ee73021ecb3e6c245ba0d4c3b92b33fe040301ac4b5L184). I've reinstated the values contained in the module.
May address the following issues: #154, #53, #51