Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

feat(monorepo): Add contributing guide#1588

Merged
trusz merged 5 commits intoopenscd:mainfrom
michelguerin:main
Dec 16, 2024
Merged

feat(monorepo): Add contributing guide#1588
trusz merged 5 commits intoopenscd:mainfrom
michelguerin:main

Conversation

@michelguerin
Copy link
Copy Markdown
Contributor

Details the installation steps to contribute as a developer.

  • Link from readme to contributing guide + refacto
  • Add .env.example file for needed environment variables
  • Add .env to .gitignore

* Link from readme to contributing guide + refacto
* Add .env.example file for needed environment variables
* Add `.env` to `.gitignore`
@michelguerin michelguerin requested a review from clepski November 8, 2024 12:14
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
@michelguerin michelguerin requested a review from clepski November 8, 2024 15:52
Comment thread README.md
@trusz
Copy link
Copy Markdown
Member

trusz commented Nov 12, 2024

We already have a CONTRIBUTING.md in the core package: https://github.com/openscd/open-scd/blob/main/packages/core/CONTRIBUTING.md

Have you took that into consideration?

@michelguerin
Copy link
Copy Markdown
Contributor Author

We already have a CONTRIBUTING.md in the core package: https://github.com/openscd/open-scd/blob/main/packages/core/CONTRIBUTING.md

Have you took that into consideration?

Oups, didn't see this. I'll merge these to file in favor of the root one. I'll make a new proposition in the next commit.

@michelguerin michelguerin requested a review from trusz November 22, 2024 12:44
@michelguerin
Copy link
Copy Markdown
Contributor Author

@trusz Update done : I removed the contributing guide from the core package and merge its content to root.

@trusz trusz merged commit dd692a8 into openscd:main Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants