Skip to content
This repository was archived by the owner on Jan 12, 2026. It is now read-only.

feat: 1596 Enable transpower publisher plugin#1598

Merged
trusz merged 5 commits intomainfrom
feat/1596-enable-publisher-plugin
Dec 3, 2024
Merged

feat: 1596 Enable transpower publisher plugin#1598
trusz merged 5 commits intomainfrom
feat/1596-enable-publisher-plugin

Conversation

@clepski
Copy link
Copy Markdown
Collaborator

@clepski clepski commented Nov 18, 2024

Changes

  • Add global styles accoring to the core API specs
  • Handle openenergytools edit events v2 (which are slighty different from open scd edit events v2)
  • Add material symbols

Demo

Add custom edtior plugin in https://openscd.github.io/open-scd/pr-preview/pr-1598/
with https://danyill.github.io/scl-editor/plugins/oscd-publisher/oscd-publisher.js

Up for discussion

  • Should both material icons and material symbols (3 mb file) be loaded? Can we stick with just one?
  • Do we want to add the publisher plugin to the default list of plugins?

closes #1596

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 18, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-03 08:55 UTC

Comment thread packages/openscd/src/addons/Editor.ts
Comment thread packages/openscd/src/addons/Editor.ts
@Sander3003
Copy link
Copy Markdown
Member

Sander3003 commented Nov 18, 2024

Should both material icons and material symbols (3 mb file) be loaded? Can we stick with just one?

Yes if it is a small fix, otherwise, keep both

Do we want to add the publisher plugin to the default list of plugins?

No, it is not a OpenSCD organisation plug-in

I'm happy with whatever the community decides (only my view, no hard requirement)

@clepski clepski marked this pull request as ready for review December 3, 2024 07:56
@trusz trusz merged commit 3697c38 into main Dec 3, 2024
@trusz trusz deleted the feat/1596-enable-publisher-plugin branch December 3, 2024 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable Publisher plugin from transpower in open scd

3 participants