[Manual Backport 2.x][CCI] Fix EUI/OUI type errors (#3798) #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwin-pc
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4861 +/- ##
==========================================
- Coverage 66.44% 66.32% -0.12%
==========================================
Files 3398 3321 -77
Lines 64871 63897 -974
Branches 10358 10112 -246
==========================================
- Hits 43102 42382 -720
+ Misses 19211 19028 -183
+ Partials 2558 2487 -71
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Cypress tests will pass once the Data explorer changes are emerged to 2.x |
AMoo-Miki
previously approved these changes
Aug 31, 2023
|
@ashwin-pc This has conflicts now... |
manasvinibs
previously approved these changes
Sep 1, 2023
|
@ashwin-pc, lemme know if you need help handling some of these conflicts. |
* Update find_test_subject imports for tests Signed-off-by: Alexei Karikov <[email protected]> * Update to available imports for findTestSubject Signed-off-by: Alexei Karikov <[email protected]> * Fix available import for Query and custom icon Signed-off-by: Alexei Karikov <[email protected]> * Add changelog entry Signed-off-by: Alexei Karikov <[email protected]> * Add ts-ignore Signed-off-by: Alexei Karikov <[email protected]> --------- Signed-off-by: Alexei Karikov <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> (cherry picked from commit 0e25f2e) Signed-off-by: Ashwin P Chandran <[email protected]>
ashwin-pc
dismissed stale reviews from manasvinibs and AMoo-Miki
via
951de8d
ashwin-pc
force-pushed
the
backport/backport-3798-to-2.x
branch
from
3bda298
to
951de8d
Compare
joshuarrrr
approved these changes
Sep 2, 2023
AMoo-Miki
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherrypick 0e25f2e from #3798