Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupOnEqualStalenessAndThreshold is flaky #13503

Closed
shiv0408 opened this issue May 2, 2024 · 1 comment
Closed

[BUG] org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupOnEqualStalenessAndThreshold is flaky #13503

shiv0408 opened this issue May 2, 2024 · 1 comment
Assignees
@kiranprakash154
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc

Comments

@shiv0408
Copy link
Member

shiv0408 commented May 2, 2024 •
edited by reta
Loading

Describe the bug

org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupOnEqualStalenessAndThreshold {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"false"}} test is flaky.

Stacktrace

java.lang.AssertionError
	at __randomizedtesting.SeedInfo.seed([83932CC34A07D754:D747DAFC72929DBA]:0)
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupOnEqualStalenessAndThreshold(IndicesRequestCacheIT.java:838)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
	at org.opensearch.test.OpenSearchTestClusterRule$1.evaluate(OpenSearchTestClusterRule.java:369)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at java.base/java.lang.Thread.run(Thread.java:1583)

Related component

Other

To Reproduce

/gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.IndicesRequestCacheIT" -Dtests.method="testCacheCleanupOnEqualStalenessAndThreshold {p0={"search.concurrent_segment_search.enabled":"false"}}" -Dtests.seed=83932CC34A07D754

Expected behavior

Test should always pass

Additional Details
@shiv0408 shiv0408 added bug Something isn't working untriaged labels May 2, 2024
@github-actions github-actions bot added the Other label May 2, 2024
@shiv0408 shiv0408 mentioned this issue May 2, 2024
Merged
8 tasks
@peternied peternied added flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc and removed untriaged Other labels May 2, 2024
This was referenced May 21, 2024
Merged
Closed
@reta reta changed the title [BUG] org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupOnEqualStalenessAndThreshold is flaky - test suite was timed out [BUG] org.opensearch.indices.IndicesRequestCacheIT.testCacheCleanupOnEqualStalenessAndThreshold is flaky Jun 4, 2024
@reta reta mentioned this issue Jun 4, 2024
Merged
9 tasks
andrross added a commit to andrross/OpenSearch that referenced this issue Jun 7, 2024
@andrross
Mute all flaky IndicesRequestCacheIT tests
6e3ad6f 
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:
opensearch-project#11374
opensearch-project#12308
opensearch-project#13540
opensearch-project#13503
opensearch-project#13711
opensearch-project#13949
opensearch-project#13437
opensearch-project#13600

Signed-off-by: Andrew Ross <[email protected]>
andrross added a commit to andrross/OpenSearch that referenced this issue Jun 7, 2024
@andrross
Mute all flaky IndicesRequestCacheIT tests
a1ec22f 
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:
- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

Signed-off-by: Andrew Ross <[email protected]>
@andrross andrross mentioned this issue Jun 7, 2024
Merged
3 tasks
andrross added a commit to andrross/OpenSearch that referenced this issue Jun 7, 2024
@andrross
Mute all flaky IndicesRequestCacheIT tests
cf42dbd 
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

Signed-off-by: Andrew Ross <[email protected]>
andrross added a commit that referenced this issue Jun 7, 2024
@andrross
Mute all flaky IndicesRequestCacheIT tests (#14077)
fbe048f 
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600

Signed-off-by: Andrew Ross <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 7, 2024
@github-actions
Mute all flaky IndicesRequestCacheIT tests (#14077)
f6f9726 
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600

Signed-off-by: Andrew Ross <[email protected]>
(cherry picked from commit fbe048f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this issue Jun 10, 2024
@opensearch-trigger-bot @github-actions
Mute all flaky IndicesRequestCacheIT tests (#14077) (#14082)
9b72166 
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600


(cherry picked from commit fbe048f)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@SwethaGuptha SwethaGuptha mentioned this issue Jun 10, 2024
Merged
9 tasks
parv0201 pushed a commit to parv0201/OpenSearch that referenced this issue Jun 10, 2024
@andrross @parv0201
Mute all flaky IndicesRequestCacheIT tests (opensearch-project#14077)
d0dd137 
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

Signed-off-by: Andrew Ross <[email protected]>
@rishabhmaurya rishabhmaurya mentioned this issue Jun 10, 2024
Merged
9 tasks
@akolarkunnu akolarkunnu mentioned this issue Jun 14, 2024
Merged
9 tasks
@kiranprakash154 kiranprakash154 mentioned this issue Jun 17, 2024
Merged
3 tasks
@DaniilRoman DaniilRoman mentioned this issue Jun 18, 2024
Merged
1 task
@reta
Copy link
Collaborator

reta commented Jun 19, 2024

Closing in favour of #14288

@reta reta closed this as completed Jun 19, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this issue Jul 24, 2024
@opensearch-trigger-bot @github-actions @kkewwei
Mute all flaky IndicesRequestCacheIT tests (opensearch-project#14077) (…
33c26a1 
…opensearch-project#14082)

These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

(cherry picked from commit fbe048f)

Signed-off-by: Andrew Ross <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this issue Aug 22, 2024
@andrross
Mute all flaky IndicesRequestCacheIT tests (opensearch-project#14077)
78a6d1f 
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

Signed-off-by: Andrew Ross <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kiranprakash154 kiranprakash154

Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc
Projects
Search Project Board
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@reta @peternied @kiranprakash154 @shiv0408