Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Streaming Indexing] Enhance RestAction with request / response streaming support #13772

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

reta
Copy link
Collaborator

@reta reta commented May 21, 2024

Description

Enhance RestAction with request / response streaming support

Related Issues

Closes #9071

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • API changes companion pull request created.
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0 labels May 21, 2024
Copy link
Contributor

❕ Gradle check result for 836c46b: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 45.90747% with 152 lines in your changes missing coverage. Please review.

Project coverage is 71.57%. Comparing base (b15cb0c) to head (aea22d9).
Report is 390 commits behind head on main.

Files Patch % Lines
.../main/java/org/opensearch/rest/RestController.java 1.88% 51 Missing and 1 partial ⚠️
.../rest/action/document/RestBulkStreamingAction.java 31.74% 42 Missing and 1 partial ⚠️
...ctor/netty4/ReactorNetty4StreamingHttpChannel.java 36.84% 23 Missing and 1 partial ⚠️
...g/opensearch/http/DefaultStreamingRestChannel.java 64.28% 7 Missing and 3 partials ⚠️
.../netty4/ReactorNetty4StreamingRequestConsumer.java 61.53% 3 Missing and 2 partials ⚠️
...ch/http/reactor/netty4/ReactorNetty4HttpChunk.java 69.23% 3 Missing and 1 partial ⚠️
...netty4/ReactorNetty4StreamingResponseProducer.java 75.00% 4 Missing ⚠️
.../src/main/java/org/opensearch/http/HttpTracer.java 0.00% 4 Missing ⚠️
...g/opensearch/http/AbstractHttpServerTransport.java 62.50% 3 Missing ⚠️
...rch/common/xcontent/support/XContentHttpChunk.java 83.33% 1 Missing and 1 partial ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13772      +/-   ##
============================================
+ Coverage     71.42%   71.57%   +0.15%     
- Complexity    59978    61714    +1736     
============================================
  Files          4985     5102     +117     
  Lines        282275   289941    +7666     
  Branches      40946    41896     +950     
============================================
+ Hits         201603   207523    +5920     
- Misses        63999    65297    +1298     
- Partials      16673    17121     +448     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta added backport 2.x Backport to 2.x branch and removed skip-changelog labels May 22, 2024
Copy link
Contributor

❕ Gradle check result for db179a3: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

✅ Gradle check result for cc21ef8: SUCCESS

Copy link
Contributor

✅ Gradle check result for b2722d3: SUCCESS

Copy link
Contributor

✅ Gradle check result for 336ba50: SUCCESS

@reta reta force-pushed the issue-9071 branch 2 times, most recently from ef8ffa3 to b809a35 Compare May 27, 2024 15:10
Copy link
Contributor

❌ Gradle check result for b809a35: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for ef8ffa3: SUCCESS

Copy link
Contributor

❌ Gradle check result for 4ee3417: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented May 27, 2024

❌ Gradle check result for 4ee3417: FAILURE

#13600

Copy link
Contributor

❕ Gradle check result for ddd06a7: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

❌ Gradle check result for 6aa0927: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator Author

reta commented May 28, 2024

❌ Gradle check result for 6aa0927: FAILURE

#13600

Copy link
Contributor

❌ Gradle check result for 6aa0927: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

dblock pushed a commit that referenced this pull request Jun 11, 2024
…ming support (#13772) (#14149)

Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit c71060e)
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Indexing Indexing, Bulk Indexing and anything related to indexing v2.15.0 Issues and PRs related to version 2.15.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Streaming Indexing] Enhance RestAction with streaming support
3 participants