Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fixes Numeric exact match queries to use range queries internally #11747

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 178a7a0 from #11209.

…1209)

* Updating numeric term and terms queries to use IODVQ

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Addressing comments

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Fix formatting

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Fix changelog

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Addressing more comments + adding tests

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* renaming yaml test

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Adding skip for bwc

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Adding new SortedUnsignedLongDocValuesSetQuery to allow for BitInteger Terms query

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Fixing some tests

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Remove duplicate skip

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Remove unused points declaration

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Change unsigned exact query to be consistent

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Use slowExactQuery from Unsigned Set Query

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Merging different yaml tests into a single test

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Updating test case for main

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

* Fix changelog

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>

---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
(cherry picked from commit 178a7a0)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jan 4, 2024

Compatibility status:

Checks if related components are compatible with change 53d886e

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Jan 4, 2024

❌ Gradle check result for 53d886e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jan 4, 2024

❌ Gradle check result for 53d886e: FAILURE

#9191

Copy link
Contributor

github-actions bot commented Jan 4, 2024

✅ Gradle check result for 53d886e: SUCCESS

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 161 lines in your changes are missing coverage. Please review.

Comparison is base (6e9837e) 71.10% compared to head (53d886e) 71.08%.

Files Patch % Lines
...org/opensearch/index/mapper/NumberFieldMapper.java 43.62% 61 Missing and 23 partials ⚠️
.../document/SortedUnsignedLongDocValuesSetQuery.java 15.09% 43 Missing and 2 partials ⚠️
.../main/java/org/apache/lucene/util/LongHashSet.java 39.62% 21 Missing and 11 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #11747      +/-   ##
============================================
- Coverage     71.10%   71.08%   -0.02%     
+ Complexity    59333    59320      -13     
============================================
  Files          4885     4887       +2     
  Lines        279508   279732     +224     
  Branches      40968    41032      +64     
============================================
+ Hits         198740   198856     +116     
- Misses        63954    63988      +34     
- Partials      16814    16888      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 1ad7a5d into 2.x Jan 4, 2024
83 of 84 checks passed
@github-actions github-actions bot deleted the backport/backport-11209-to-2.x branch January 4, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v2.12.0 Issues and PRs related to version 2.12.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant