Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump peternied/required-approval from v1.2 to v1.3 #11820

Merged
merged 6 commits into from
Jan 9, 2024

Conversation

peternied
Copy link
Member

@peternied peternied commented Jan 9, 2024

Description

Bump peternied/required-approval from v1.2 to v1.3

  • New version adds supports pagination for pull requests with many reviews which has impact longer pull requests.
  • Check is also run after any review is summited so approves don't need to dismiss and reapprove.

Related Issues

Testing

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Compatibility status:

Checks if related components are compatible with change 6fccb44

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

github-actions bot commented Jan 9, 2024

❕ Gradle check result for 6fccb44: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.classMethod
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.index.shard.RemoteStoreRefreshListenerTests.testRefreshAfterCommit

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1e4602) 71.43% compared to head (6fccb44) 70.75%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #11820      +/-   ##
============================================
- Coverage     71.43%   70.75%   -0.69%     
+ Complexity    59259    58798     -461     
============================================
  Files          4912     4912              
  Lines        278733   278733              
  Branches      40529    40529              
============================================
- Hits         199107   197208    -1899     
- Misses        63065    65107    +2042     
+ Partials      16561    16418     -143     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta merged commit 3f5ec64 into opensearch-project:main Jan 9, 2024
39 checks passed
@reta reta added the backport 2.x Backport to 2.x branch label Jan 9, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 9, 2024
* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Use required-approval@main

* Trigger on any review

Signed-off-by: Peter Nied <[email protected]>

* Snap to version v1.3

Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
(cherry picked from commit 3f5ec64)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jan 9, 2024
* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874




* Changelog entry




* Use required-approval@main

* Trigger on any review



* Snap to version v1.3



---------



(cherry picked from commit 3f5ec64)

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…t#11820)

* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Use required-approval@main

* Trigger on any review

Signed-off-by: Peter Nied <[email protected]>

* Snap to version v1.3

Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…t#11820)

* Switched to more reliable OpenSearch Lucene snapshot location

- Related opensearch-project/opensearch-build#3874

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Changelog entry

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>

* Use required-approval@main

* Trigger on any review

Signed-off-by: Peter Nied <[email protected]>

* Snap to version v1.3

Signed-off-by: Peter Nied <[email protected]>

---------

Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Peter Nied <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants