Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log appender in InsecureSettingTests #11866

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Fix log appender in InsecureSettingTests #11866

merged 3 commits into from
Jan 12, 2024

Commits on Jan 12, 2024

  1. Fix log appender in InsecureSettingTests 

    The appender was being added to the logger before the appender was
started. This can lead to logger errors with concurrently running tests
because the logger is static state shared across the JVM. See opensearch-project#10799.

I've also added a removeAppender call that was missing from
LoggersTests, but that is mostly hygiene and would not lead to failures.

Signed-off-by: Andrew Ross <[email protected]>
    @andrross
    andrross committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    47a6261 View commit details
    Browse the repository at this point in the history

  2. Do not use root logger to further isolate test 

    Signed-off-by: Andrew Ross <[email protected]>
    @andrross
    andrross committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    1b47f08 View commit details
    Browse the repository at this point in the history

  3. Spotless fix 

    Signed-off-by: Andrew Ross <[email protected]>
    @andrross
    andrross committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    124d166 View commit details
    Browse the repository at this point in the history