Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Prevent version upgrade during remote migration (#13185) #13347

Merged

Conversation

ltaragi
Copy link
Contributor

@ltaragi ltaragi commented Apr 23, 2024

Signed-off-by: Lakshya Taragi [email protected]
(cherry picked from commit 2aad499)

Description

Backport #13185 to 2.x

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 1fee822: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ltaragi ltaragi force-pushed the backport/backport-13185-to-2.x branch from 1fee822 to 94fae50 Compare April 23, 2024 12:06
Copy link
Contributor

✅ Gradle check result for 94fae50: SUCCESS

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 71.06%. Comparing base (0dd892c) to head (94fae50).
Report is 166 commits behind head on 2.x.

Files Patch % Lines
...nsearch/cluster/coordination/JoinTaskExecutor.java 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13347      +/-   ##
============================================
- Coverage     71.28%   71.06%   -0.23%     
- Complexity    60145    60550     +405     
============================================
  Files          4957     5005      +48     
  Lines        282799   285469    +2670     
  Branches      41409    41735     +326     
============================================
+ Hits         201591   202858    +1267     
- Misses        64189    65504    +1315     
- Partials      17019    17107      +88     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit cce8f63 into opensearch-project:2.x Apr 23, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants