Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capability to disable source recovery_source for an index #13590

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

navneet1v
Copy link
Contributor

@navneet1v navneet1v commented May 7, 2024

Description

This change will add the capability where a user can disable the recovery_source, just like user can disable source. Disabling of _recovery_source can be done per field by mentioning the field names too in includes and excludes.

Example of an Index Mappings where both source and recovery source is disabled:

PUT my-index
{
	"settings": {
		"index": {
			"number_of_shards": 3,
			"refresh_interval": "1s"
		}
	},
	"mappings": {
		"_source": {
			"enabled": false,
			"recovery_source_enabled": false
		},
			"properties": {
				"title": {
					"type": "text"
				}
			}
		}
}

Related Issues

Resolves #13490

Related Issue: opensearch-project/k-NN#1599

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented May 7, 2024

❌ Gradle check result for beb57cf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 7, 2024

❌ Gradle check result for a6dcdfb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented May 8, 2024

❌ Gradle check result for fe19810: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

navneet1v added a commit to navneet1v/OpenSearch that referenced this pull request Jun 7, 2024
navneet1v added a commit to navneet1v/OpenSearch that referenced this pull request Jun 7, 2024
navneet1v added a commit to navneet1v/OpenSearch that referenced this pull request Jun 7, 2024
navneet1v added a commit to navneet1v/OpenSearch that referenced this pull request Jun 7, 2024
navneet1v added a commit to navneet1v/OpenSearch that referenced this pull request Jun 8, 2024
navneet1v added a commit to navneet1v/OpenSearch that referenced this pull request Jun 8, 2024
navneet1v added a commit to navneet1v/OpenSearch that referenced this pull request Jun 9, 2024
navneet1v added a commit to navneet1v/OpenSearch that referenced this pull request Jun 10, 2024
parv0201 pushed a commit to parv0201/OpenSearch that referenced this pull request Jun 10, 2024
navneet1v added a commit to navneet1v/OpenSearch that referenced this pull request Jun 10, 2024
shwetathareja pushed a commit that referenced this pull request Jun 11, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed enhancement Enhancement or improvement to existing feature or request Indexing:Performance
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request] Capability to remove _recovery_source per field
4 participants