[Backport 2.x] Main repository azure managed identity support #13661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
reta
approved these changes
May 14, 2024
|
❌ Gradle check result for 23a044f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Blocked by #13663 |
andrross
approved these changes
May 14, 2024
kotwanikunal
approved these changes
May 14, 2024
* Added support for Azure Managed Identity in repository-azure Signed-off-by: Chengwu Shi <[email protected]> * Refactor tokenCredentialType as an enum when constructing AzureStorageSetting Signed-off-by: Chengwu Shi <[email protected]> * fixed indentation Signed-off-by: Chengwu Shi <[email protected]> * fixed syntax Signed-off-by: Chengwu Shi <[email protected]> * removed unused imports Signed-off-by: Chengwu Shi <[email protected]> * applied changes after running :plugins:repository-azure:spotlessApply Signed-off-by: Chengwu Shi <[email protected]> * added transitive dependencies Signed-off-by: Chengwu Shi <[email protected]> * changed getStorageBlobEndpoint to private and using asm version from buildSrc/version.properties Signed-off-by: Chengwu Shi <[email protected]> * run spotlessApply Signed-off-by: Chengwu Shi <[email protected]> * update shas for asm 9.7 Signed-off-by: Chengwu Shi <[email protected]> * use version.jna for jna-platform Signed-off-by: Chengwu Shi <[email protected]> * change string 'core.windows.net' to be a constant, use uri.create instead of new uri, and added a few comments for clarity Signed-off-by: Chengwu Shi <[email protected]> * added one more comment line Signed-off-by: Chengwu Shi <[email protected]> * refactor TokenCredentialType to not have NOT_APPLICABLE Signed-off-by: Chengwu Shi <[email protected]> * refactored code based on recommended changes from Andriy Redko Signed-off-by: Chengwu Shi <[email protected]> * added a jvm security policy for reactor-core jar Signed-off-by: Chengwu Shi <[email protected]> * fixed failing forbidden api fix Signed-off-by: Chengwu Shi <[email protected]> * removed the jvm security policy for reactor-core which was added Signed-off-by: Chengwu Shi <[email protected]> * refactored code, such that storage endpoint is not evaluated at compiled time Signed-off-by: Chengwu Shi <[email protected]> * refactored token credential types checks Signed-off-by: Chengwu Shi <[email protected]> * changed clientlogger in azurestoragesetting to 'AzureStorageService' Signed-off-by: Chengwu Shi <[email protected]> * added a nullable argument to getStorageEndpoint Signed-off-by: Chengwu Shi <[email protected]> * Fix IdentityClient security permissions, get rid of connection string (since it is not applicable to managed identity configuration) Signed-off-by: Andriy Redko <[email protected]> * Responded to feedback from Andrew Ross, fixed typo, spelling, added shudownNow() and Thread.currentThread().interrupt() Signed-off-by: Chengwu Shi <[email protected]> --------- Signed-off-by: Chengwu Shi <[email protected]> Signed-off-by: Andriy Redko <[email protected]> Co-authored-by: Andriy Redko <[email protected]> (cherry picked from commit a03db0d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
force-pushed
the
backport/backport-12559-to-2.x
branch
from
23a044f
to
d4de531
Compare
reta
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport a03db0d from #12559.