[Flaky Test] Set refresh interval to -1 to only have 1 segment #14201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bowenlan-amzn <[email protected]>
github-actions
bot
added
bug
bowenlan-amzn
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
mch2
approved these changes
Jun 11, 2024
|
❌ Gradle check result for bfe5a93: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14201 +/- ##
============================================
+ Coverage 71.42% 71.59% +0.17%
- Complexity 59978 61872 +1894
============================================
Files 4985 5117 +132
Lines 282275 291173 +8898
Branches 40946 42067 +1121
============================================
+ Hits 201603 208456 +6853
- Misses 63999 65513 +1514
- Partials 16673 17204 +531 ☔ View full report in Codecov by Sentry. |
mch2
approved these changes
Jun 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Signed-off-by: bowenlan-amzn <[email protected]> (cherry picked from commit c381b34) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mch2
pushed a commit
that referenced
this pull request
Jun 12, 2024
(cherry picked from commit c381b34) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Jun 13, 2024
3 tasks
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
Signed-off-by: bowenlan-amzn <[email protected]>
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…ject#14212) (cherry picked from commit c381b34) Signed-off-by: bowenlan-amzn <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
Signed-off-by: bowenlan-amzn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Failed 3 times in gradle check after merging in the change on 5/2 Metric Dashboard Link
Example Failure
https://build.ci.opensearch.org/job/gradle-check/39719/testReport/junit/org.opensearch.test.rest/ClientYamlTestSuiteIT/test__p0_search_aggregation_230_composite_composite_aggregation_date_histogram_profile_shows_filter_rewrite_info__2/
We can see the flaky is because sometime there are 2 segments instead of 1 though we are bulk indexing just 4 documents. After discussing with @mch2 , this could because the background refresh race in. So we are setting refresh_interval to -1 now to eliminate that.
Related Issues
Resolves #13971
Check List
[ ] API changes companion pull request created, if applicable.[ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.