[Streaming Indexing] Enhance RestClient with a new streaming API support #14437
Conversation
github-actions
bot
added
Build Libraries & Interfaces
enhancement
|
❌ Gradle check result for a6ec079: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 5b112c6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 4afb721: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14437 +/- ##
============================================
- Coverage 71.77% 71.69% -0.08%
+ Complexity 62302 62229 -73
============================================
Files 5125 5128 +3
Lines 292473 292596 +123
Branches 42258 42268 +10
============================================
- Hits 209912 209767 -145
- Misses 65324 65528 +204
- Partials 17237 17301 +64 ☔ View full report in Codecov by Sentry. |
| @@ -3,5 +3,8 @@ | |||
| <exclusions> | |||
| <module name="org.jboss.resteasy.resteasy-jackson2-provider" /> | |||
| </exclusions> | |||
| <dependencies> | |||
There was a problem hiding this comment.
Not really related to this PR, but do you think this wildfly subproject is adding value? According to the developer guide, this exists to test clients in "interesting" places so I suppose it is somewhat relevant here. Would you consider adding HTTP/2 or streaming specific tests to this package? If not, I'm going to question its value :)
The primary overhead of this subproject is that it brings in dependencies like resteasy that otherwise wouldn't be here.
There was a problem hiding this comment.
Would you consider adding HTTP/2 or streaming specific tests to this package? If not, I'm going to question its value :)
I am working on test cases as we speak :) I think we could definitely add streaming tests there, thanks a lot for the idea @andrross !
|
❕ Gradle check result for 6150ca1: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
|
❌ Gradle check result for 07b0ec0: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for caadea4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for d261cd6: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Andriy Redko <[email protected]>
Description
Enhance
RestClientwith a new streaming API supportRelated Issues
Resolves #9072
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.