Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use circuit breaker in InternalHistogram when adding empty buckets (#14754) #14844

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

bowenlan-amzn
Copy link
Member

@bowenlan-amzn bowenlan-amzn commented Jul 19, 2024

Description

backport #14754

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…pensearch-project#14754)

* introduce circuit breaker in InternalHistogram

Signed-off-by: bowenlan-amzn <[email protected]>

* use circuit breaker from reduce context

Signed-off-by: bowenlan-amzn <[email protected]>

* add test

Signed-off-by: bowenlan-amzn <[email protected]>

* revert use_real_memory change in OpenSearchNode

Signed-off-by: bowenlan-amzn <[email protected]>

* add change log

Signed-off-by: bowenlan-amzn <[email protected]>

---------

Signed-off-by: bowenlan-amzn <[email protected]>
Copy link
Contributor

✅ Gradle check result for 21be116: SUCCESS

Copy link

codecov bot commented Jul 20, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.57%. Comparing base (c3bcea6) to head (21be116).
Report is 1 commits behind head on 2.x.

Files Patch % Lines
...gregations/bucket/histogram/InternalHistogram.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14844      +/-   ##
============================================
+ Coverage     71.50%   71.57%   +0.06%     
+ Complexity    62503    62495       -8     
============================================
  Files          5106     5106              
  Lines        293625   293631       +6     
  Branches      42779    42779              
============================================
+ Hits         209967   210173     +206     
+ Misses        66057    65770     -287     
- Partials      17601    17688      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mch2 mch2 merged commit e6e62bb into opensearch-project:2.x Jul 20, 2024
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants