Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.16] [Backport 2.x] Add SortResponseProcessor to Search Pipelines (#14785) #14873

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 10bdfee from #14868.

* Add SortResponseProcessor for search pipelines

* Add stupid and unnecessary javadocs to satisfy overly strict CI

* Split casting and sorting methods for readability

* Register the sort processor factory

* Address code review comments

* Cast individual list elements to avoid creating two lists

* Add yamlRestTests

* Clarify why there's unusual sorting

* Use instanceof instead of isAssignableFrom

---------

Signed-off-by: Daniel Widdis <[email protected]>
(cherry picked from commit 10bdfee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Gradle check result for 92629cd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 92629cd: SUCCESS

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 82.25806% with 11 lines in your changes missing coverage. Please review.

Project coverage is 71.54%. Comparing base (82cb703) to head (92629cd).

Files Patch % Lines
.../search/pipeline/common/SortResponseProcessor.java 81.96% 5 Missing and 6 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               2.16   #14873      +/-   ##
============================================
- Coverage     71.55%   71.54%   -0.01%     
- Complexity    62527    62560      +33     
============================================
  Files          5109     5110       +1     
  Lines        293687   293748      +61     
  Branches      42791    42803      +12     
============================================
+ Hits         210135   210171      +36     
+ Misses        65922    65914       -8     
- Partials      17630    17663      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 717a16d into 2.16 Jul 22, 2024
52 checks passed
@dbwiddis dbwiddis deleted the backport/backport-14868-to-2.16 branch July 22, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant