Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Removing String format in RemoteStoreMigrationAllocationDecider #14874

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

RS146BIJAY
Copy link
Contributor

Backport e82b432 from #14612.

…timise performance(opensearch-project#14612)

Signed-off-by: RS146BIJAY <[email protected]>
(cherry picked from commit e82b432)
Copy link
Contributor

❌ Gradle check result for 35c5c60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@dblock
Copy link
Member

dblock commented Jul 22, 2024

Any reason this is not ready for review @RS146BIJAY?

Copy link
Contributor

❌ Gradle check result for 35c5c60: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 35c5c60: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❕ Gradle check result for 35c5c60: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (7755055) to head (35c5c60).
Report is 8 commits behind head on 2.x.

Files Patch % Lines
...decider/RemoteStoreMigrationAllocationDecider.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                2.x   #14874   +/-   ##
=========================================
  Coverage     71.58%   71.58%           
+ Complexity    62544    62494   -50     
=========================================
  Files          5108     5108           
  Lines        293645   293653    +8     
  Branches      42781    42781           
=========================================
+ Hits         210205   210215   +10     
- Misses        65741    65780   +39     
+ Partials      17699    17658   -41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RS146BIJAY
Copy link
Contributor Author

RS146BIJAY commented Jul 23, 2024

Any reason this is not ready for review @RS146BIJAY?

I was waiting for the build to pass. Published the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants