Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Use default value when index.number_of_replicas is null #14906

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e485856 from #14812.

* Use default value when index.number_of_replicas is null

Signed-off-by: Liyun Xiu <[email protected]>

* Add integration test

Signed-off-by: Liyun Xiu <[email protected]>

* Add changelog

Signed-off-by: Liyun Xiu <[email protected]>

---------

Signed-off-by: Liyun Xiu <[email protected]>
(cherry picked from commit e485856)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Gradle check result for 9cafa07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

✅ Gradle check result for 9cafa07: SUCCESS

Copy link

codecov bot commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.53%. Comparing base (a0a7098) to head (9cafa07).
Report is 3 commits behind head on 2.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #14906      +/-   ##
============================================
- Coverage     71.60%   71.53%   -0.08%     
+ Complexity    62639    62569      -70     
============================================
  Files          5117     5117              
  Lines        293941   293942       +1     
  Branches      42834    42835       +1     
============================================
- Hits         210466   210258     -208     
- Misses        65813    66007     +194     
- Partials      17662    17677      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dblock dblock merged commit 0cfde64 into 2.x Jul 23, 2024
52 checks passed
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…roject#14812) (opensearch-project#14906)

* Use default value when index.number_of_replicas is null

* Add integration test

* Add changelog

---------

(cherry picked from commit e485856)

Signed-off-by: Liyun Xiu <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <[email protected]>
@dbwiddis dbwiddis deleted the backport/backport-14812-to-2.x branch July 24, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant