-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setting API honors cluster's replica setting as default #14810 #14948
base: main
Are you sure you want to change the base?
Conversation
❕ Gradle check result for f9e019f: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
❕ Gradle check result for a7d986e: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14948 +/- ##
============================================
+ Coverage 71.92% 71.95% +0.03%
- Complexity 64400 64413 +13
============================================
Files 5281 5281
Lines 300995 300996 +1
Branches 43479 43479
============================================
+ Hits 216491 216590 +99
+ Misses 66793 66598 -195
- Partials 17711 17808 +97 ☔ View full report in Codecov by Sentry. |
❌ Gradle check result for b690c89: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for e16d52f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 157b40c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 46ba1fe: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me, please resolve the conflicts and make sure all gradle checks pass, thanks!
…arch-project#14810 Signed-off-by: Liyun Xiu <[email protected]>
❌ Gradle check result for e6b8976: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 238b01e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 21e4a19: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Signed-off-by: Liyun Xiu <[email protected]>
❕ Gradle check result for 9286a1b: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
@gaobinlong I resolved conflict and all gradle checks passed |
@chishui could you open a documentation PR about this behavior in this repo? Maybe add it here: dynamic-index-level-index-settings, and we even don't have some documentation about the cluster level setting |
Description
This is a fix to #14810.
When user calls
Previous logic is always set
index.number_of_replicas
to 1. This PR changes the default value to the one configured by cluster settingcluster.default_number_of_replicas
and if it's not configured, a same default 1 will be used. It's consistent to the default replica value when creating an index.Related Issues
#14810
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.