Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cluster state checksum in manifest #15218

Merged
merged 36 commits into from
Sep 3, 2024

Conversation

himshikha
Copy link
Contributor

Description

Adds a checksum for cluster state components to remote publication manifest. This will be behind a feature flag and will be used to validate cluster state created in follower nodes matches the cluster state on cluster manager.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

❌ Gradle check result for 379fe90: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Himshikha Gupta added 2 commits August 16, 2024 15:51
Signed-off-by: Himshikha Gupta <[email protected]>
Signed-off-by: Himshikha Gupta <[email protected]>
Copy link
Contributor

❌ Gradle check result for 859da07: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 64af94a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for 475544a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Himshikha Gupta <[email protected]>
Copy link
Contributor

github-actions bot commented Sep 3, 2024

✅ Gradle check result for 18b8cd0: SUCCESS

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 74.36893% with 132 lines in your changes missing coverage. Please review.

Project coverage is 71.86%. Comparing base (33be5a9) to head (18b8cd0).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 33.33% 54 Missing and 10 partials ⚠️
...main/java/org/opensearch/cluster/ClusterState.java 4.00% 24 Missing ⚠️
...common/io/stream/BufferedChecksumStreamOutput.java 72.09% 12 Missing ⚠️
...pensearch/gateway/remote/ClusterStateChecksum.java 94.36% 6 Missing and 6 partials ⚠️
...va/org/opensearch/cluster/node/DiscoveryNodes.java 58.33% 1 Missing and 9 partials ⚠️
...search/gateway/remote/ClusterMetadataManifest.java 85.18% 1 Missing and 3 partials ⚠️
...search/cluster/routing/IndexShardRoutingTable.java 82.35% 3 Missing ⚠️
.../java/org/opensearch/cluster/AbstractDiffable.java 0.00% 1 Missing ⚠️
...org/opensearch/cluster/metadata/IndexMetadata.java 94.73% 0 Missing and 1 partial ⚠️
...opensearch/cluster/metadata/TemplatesMetadata.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #15218      +/-   ##
============================================
- Coverage     71.99%   71.86%   -0.14%     
- Complexity    63924    63945      +21     
============================================
  Files          5257     5258       +1     
  Lines        298667   299167     +500     
  Branches      43184    43229      +45     
============================================
- Hits         215028   214990      -38     
- Misses        65972    66516     +544     
+ Partials      17667    17661       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bukhtawar Bukhtawar merged commit 82762d4 into opensearch-project:main Sep 3, 2024
34 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-15218-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82762d4b1a8700eb05708d223ba6b50c0c2fbc3c
# Push it to GitHub
git push --set-upstream origin backport/backport-15218-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-15218-to-2.x.

himshikha added a commit to himshikha/OpenSearch that referenced this pull request Sep 3, 2024
* Add cluster state checksum in manifest for remote state and routing table publication

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Bukhtawar Khan <[email protected]>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.17 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.17
# Create a new branch
git switch --create backport/backport-15218-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 82762d4b1a8700eb05708d223ba6b50c0c2fbc3c
# Push it to GitHub
git push --set-upstream origin backport/backport-15218-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.17

Then, create a pull request where the base branch is 2.17 and the compare/head branch is backport/backport-15218-to-2.17.

himshikha added a commit to himshikha/OpenSearch that referenced this pull request Sep 4, 2024
* Add cluster state checksum in manifest for remote state and routing table publication

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Bukhtawar Khan <[email protected]>
Bukhtawar added a commit that referenced this pull request Sep 4, 2024
* Add cluster state checksum in manifest (#15218)

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Bukhtawar Khan <[email protected]>
Bukhtawar added a commit that referenced this pull request Sep 4, 2024
* Add cluster state checksum in manifest for remote state and routing table publication

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Bukhtawar Khan <[email protected]>
akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request Sep 10, 2024
* Add cluster state checksum in manifest for remote state and routing table publication

Signed-off-by: Himshikha Gupta <[email protected]>
Co-authored-by: Bukhtawar Khan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants