Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for race condition in node-join/node-left loop #15521

Merged
merged 36 commits into from
Sep 28, 2024
Merged

Fix for race condition in node-join/node-left loop #15521

merged 36 commits into from
Sep 28, 2024

Commits on Sep 25, 2024

  1. Add custom connect to node for handleJoinRequest + info logs + comments 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4d5c105 View commit details
    Browse the repository at this point in the history

  2. spotless apply and import cleanup 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    85905ee View commit details
    Browse the repository at this point in the history

  3. Update system.out to logger.info 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f3efb03 View commit details
    Browse the repository at this point in the history

  4. Changes to mark disconnects as part of publish 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    f5fa846 View commit details
    Browse the repository at this point in the history

  5. cleanup unused code and remove added log lines 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2db5587 View commit details
    Browse the repository at this point in the history

  6. Move all logic to transportService/ClusterConnectionManager as per co… 

    …mments

Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    12b89b4 View commit details
    Browse the repository at this point in the history

  7. apply spotless 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e8029c9 View commit details
    Browse the repository at this point in the history

  8. remove log line 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    eb58389 View commit details
    Browse the repository at this point in the history

  9. fix merge conflict 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    136aa4f View commit details
    Browse the repository at this point in the history

  10. remove log line 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    514ec9f View commit details
    Browse the repository at this point in the history

  11. Additional check to fix UTs 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    c5bcafa View commit details
    Browse the repository at this point in the history

  12. empty commit for gradle check rerun 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    dddeb0b View commit details
    Browse the repository at this point in the history

  13. fix log 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    38b1086 View commit details
    Browse the repository at this point in the history

  14. cleanup 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    82748db View commit details
    Browse the repository at this point in the history

  15. rename variable names, update logs and comments 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    ec9a007 View commit details
    Browse the repository at this point in the history

  16. add changelog 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0964e0b View commit details
    Browse the repository at this point in the history

  17. Address comments + minor changes 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a0f45b9 View commit details
    Browse the repository at this point in the history

  18. fix targetsbynode logic 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    3c0ff58 View commit details
    Browse the repository at this point in the history

  19. fix tests instead of updating disconnectFromNodesExcept 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    4555c79 View commit details
    Browse the repository at this point in the history

  20. Minor changes in IT 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6c963b4 View commit details
    Browse the repository at this point in the history

  21. empty commit for gradle check 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    cba4b9b View commit details
    Browse the repository at this point in the history

  22. Add test for disconnect during node-left 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    47c1141 View commit details
    Browse the repository at this point in the history

  23. fix spotless 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    36d84c7 View commit details
    Browse the repository at this point in the history

  24. Cleanup pendingDisconnection entries during cluster-manager failover 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    678ebd0 View commit details
    Browse the repository at this point in the history

  25. Use NodeConnectionsService instead of transportService in Coordinator 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    6aa25ee View commit details
    Browse the repository at this point in the history

  26. remove doc from IT 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a23214a View commit details
    Browse the repository at this point in the history

  27. empty commit to rerun gradle check 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b761900 View commit details
    Browse the repository at this point in the history

  28. change debug logs to trace logs to remove noise 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    36a300d View commit details
    Browse the repository at this point in the history

  29. add new tests and refactor existing tests 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    5cf7a51 View commit details
    Browse the repository at this point in the history

  30. remove unused code 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    fff66e1 View commit details
    Browse the repository at this point in the history

  31. add assertions on exception message 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    db3d23a View commit details
    Browse the repository at this point in the history

  32. changes to tests based on comments 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    a6a6c38 View commit details
    Browse the repository at this point in the history

  33. empty commit 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    1ded2cc View commit details
    Browse the repository at this point in the history

  34. update nodeconnectionsservice test 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    9a060cc View commit details
    Browse the repository at this point in the history

  35. empty commit for gradle check 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    7b0d28b View commit details
    Browse the repository at this point in the history

  36. empty commit 

    Signed-off-by: Rahul Karajgikar <[email protected]>
    Rahul Karajgikar committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    e0a0ae2 View commit details
    Browse the repository at this point in the history