Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Introduce ApproximateRangeQuery and ApproximateableQuery (#13788) #15586

Merged

Conversation

harshavamsi
Copy link
Contributor

Backport #13788 to 2.x


Signed-off-by: Harsha Vamsi Kalluri [email protected]
Signed-off-by: Michael Froh [email protected]
Co-authored-by: Michael Froh [email protected]
(cherry picked from commit 2e9db40)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ect#13788)

This introduces a basic "approximation" framework that improves
query performance by modifying the query in a way that should be
functionally equivalent.

To start, we can reduce the bounds of a range query in order to
satisfy the `track_total_hits` value (which defaults to 10,000).

---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Michael Froh <[email protected]>
Co-authored-by: Michael Froh <[email protected]>
(cherry picked from commit 2e9db40)
Copy link
Contributor

github-actions bot commented Sep 2, 2024

❌ Gradle check result for cc1175d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi harshavamsi closed this Sep 3, 2024
@harshavamsi harshavamsi reopened this Sep 3, 2024
Copy link
Contributor

github-actions bot commented Sep 3, 2024

❌ Gradle check result for cc1175d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi harshavamsi closed this Sep 4, 2024
@harshavamsi harshavamsi reopened this Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for cc1175d: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi harshavamsi closed this Sep 4, 2024
@harshavamsi harshavamsi reopened this Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for cc1175d: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for cc1175d: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for cc1175d: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi harshavamsi closed this Sep 4, 2024
@harshavamsi harshavamsi reopened this Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

❌ Gradle check result for cc1175d: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@harshavamsi harshavamsi closed this Sep 4, 2024
@harshavamsi harshavamsi reopened this Sep 4, 2024
Copy link
Contributor

github-actions bot commented Sep 4, 2024

✅ Gradle check result for cc1175d: SUCCESS

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 31.92308% with 177 lines in your changes missing coverage. Please review.

Project coverage is 71.70%. Comparing base (834b7c1) to head (cc1175d).
Report is 30 commits behind head on 2.x.

Files with missing lines Patch % Lines
...search/approximate/ApproximatePointRangeQuery.java 34.67% 115 Missing and 15 partials ⚠️
...arch/search/approximate/ApproximateScoreQuery.java 18.51% 21 Missing and 1 partial ⚠️
.../approximate/ApproximateIndexOrDocValuesQuery.java 23.52% 13 Missing ⚠️
...a/org/opensearch/index/mapper/DateFieldMapper.java 18.18% 6 Missing and 3 partials ⚠️
...ensearch/search/internal/ContextIndexSearcher.java 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #15586      +/-   ##
============================================
- Coverage     71.73%   71.70%   -0.04%     
- Complexity    63966    64048      +82     
============================================
  Files          5241     5245       +4     
  Lines        299111   299364     +253     
  Branches      43539    43600      +61     
============================================
+ Hits         214569   214658      +89     
- Misses        66626    66798     +172     
+ Partials      17916    17908       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@msfroh msfroh changed the title Backport (#13788) [Backport 2.x] Introduce ApproximateRangeQuery and ApproximateableQuery (#13788) Sep 4, 2024
@msfroh msfroh merged commit 3ddb199 into opensearch-project:2.x Sep 4, 2024
263 of 286 checks passed
@harshavamsi harshavamsi deleted the backport/backport-13788-to-2.x branch September 4, 2024 22:07
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 4, 2024
This introduces a basic "approximation" framework that improves
query performance by modifying the query in a way that should be
functionally equivalent.

To start, we can reduce the bounds of a range query in order to
satisfy the `track_total_hits` value (which defaults to 10,000).

---------

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Michael Froh <[email protected]>
Co-authored-by: Michael Froh <[email protected]>
(cherry picked from commit 2e9db40)
(cherry picked from commit 3ddb199)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh added a commit that referenced this pull request Sep 4, 2024
#15700)

This introduces a basic "approximation" framework that improves
query performance by modifying the query in a way that should be
functionally equivalent.

To start, we can reduce the bounds of a range query in order to
satisfy the `track_total_hits` value (which defaults to 10,000).

---------




(cherry picked from commit 2e9db40)
(cherry picked from commit 3ddb199)

Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Froh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants