Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workload Management] QueryGroup Stats API Logic #15777

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

[Workload Management] QueryGroup Stats API Logic #15777

wants to merge 24 commits into from
+731 −16

Conversation

ruai0511
Copy link
Contributor

@ruai0511 ruai0511 commented Sep 5, 2024 •
edited
Loading

Description

This change introduces the QueryGroup Stats API as part of this RFC: #12342.

The QueryGroup Stats API schema is:

curl -XGET "localhost:9200/_wlm/stats"

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ruai0511 ruai0511 force-pushed the querygroupstats-PR branch 3 times, most recently from 88c9cff to b66823c Compare September 5, 2024 21:28
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for f647487: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for 88c9cff: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Gradle check result for b66823c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ruai0511 ruai0511 added the backport 2.x Backport to 2.x branch label Sep 5, 2024
@ruai0511
add tests
af3e8b7 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
modify uri
558fe7b 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
address comments
9690119 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
modify based on comments
cd1c4c8 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
changelog
4ce18dd 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
address comments
89289c7 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
add tests
d10c7f9 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
modify uri
5c8e725 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
modify based on comments
103fd83 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
modify based on comments
9773ea3 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
revise
2042dfa 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
address comments
f342049 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
changelog
942ed9b 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
address comments
b454435 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
add tests
47a6fa6 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
modify uri
fc8ffe8 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
modify based on comments
d9494fd 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
modify based on comments
f0d10ae 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
git pull
7f52c52 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
rebase
62fbd5e 
Signed-off-by: Ruirui Zhang <[email protected]>
@ruai0511
encapsulate querygroupstats in wlmstats
ff4145c 
Signed-off-by: Ruirui Zhang <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for d1d7441: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@jainankitk
Copy link
Collaborator

@ruai0511 - Precommit is failing, can you address that?

jainankitk
jainankitk requested changes Oct 9, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
server/src/main/java/org/opensearch/node/Node.java Outdated
Comment on lines 1152 to 1185
final SearchRequestOperationsCompositeListenerFactory searchRequestOperationsCompositeListenerFactory =
new SearchRequestOperationsCompositeListenerFactory(
Stream.concat(
Stream.of(
searchRequestStats,
searchRequestSlowLog,
searchTaskRequestOperationsListener,
queryGroupRequestOperationListener
),
pluginComponents.stream()
.filter(p -> p instanceof SearchRequestOperationsListener)
.map(p -> (SearchRequestOperationsListener) p)
).toArray(SearchRequestOperationsListener[]::new)
);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need TransportService into QueryGroupService. The nodeStats within QueryGroupService should be completely oblivious of the localNodeId. It should just return the new QueryGroupStats(statsHolderMap). TransportAction can create the WlmStats object from QueryGroupStats.

server/src/main/java/org/opensearch/wlm/QueryGroupService.java Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for f8e6ac4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ruai0511
fix UT
7dcd545 
Signed-off-by: Ruirui Zhang <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

❌ Gradle check result for 7dcd545: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushalmahi12 kaushalmahi12 kaushalmahi12 approved these changes

@jainankitk jainankitk jainankitk requested changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jed326 jed326 Awaiting requested review from jed326

@peternied peternied Awaiting requested review from peternied

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ruai0511 @sgup432 @jainankitk @kaushalmahi12