Fix flaky tests in SnapshotStatusApisIT #16146
Merged
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lakshya Taragi <[email protected]>
github-actions
bot
added
>test-failure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16146 +/- ##
============================================
- Coverage 71.89% 71.88% -0.01%
+ Complexity 64466 64457 -9
============================================
Files 5288 5288
Lines 301439 301439
Branches 43552 43552
============================================
- Hits 216706 216700 -6
- Misses 66931 66995 +64
+ Partials 17802 17744 -58 ☔ View full report in Codecov by Sentry. |
ltaragi
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
jainankitk,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
gbbafna
approved these changes
Oct 1, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Lakshya Taragi <[email protected]> (cherry picked from commit 43e7597) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
pushed a commit
that referenced
this pull request
Oct 1, 2024
(cherry picked from commit 43e7597) Signed-off-by: Lakshya Taragi <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
hainenber
pushed a commit
to hainenber/OpenSearch
that referenced
this pull request
Oct 1, 2024
Signed-off-by: Lakshya Taragi <[email protected]>
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The following two tests started failing repeatedly from 8/27 to 9/4 and stopped afterwards
org.opensearch.snapshots.SnapshotStatusApisIT.testStatusAPICallForShallowCopySnapshotorg.opensearch.snapshots.SnapshotStatusApisIT.testExceptionOnMissingShardLevelSnapBlobDashboard
Both the tests failed with
SnapshotMissingException. The failures were likely due to commits yet to be merged as part of Snapshot Scaling (#15084). As a preventive measure, we have usedassertBusyand ran the test class locally for over 4.5K runs without any failures.Related Issues
Resolves #15815
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.