Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TLSv1.3 in jdk.tls.client.protocols systemProp in gradle.properties #16237

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Oct 8, 2024

Description

This system property was introduced in 34ccd3f to resolve an issue connecting to services at build time that did not support TLSv1.3.

I'm opening this PR to add TLSv1.3 to this systemProp.

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

❌ Gradle check result for 655f784: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Oct 8, 2024

❕ Gradle check result for 655f784: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.search.SearchTimeoutIT.testSimpleTimeout {p0={"search.concurrent_segment_search.enabled":"true"}}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.05%. Comparing base (a81b868) to head (da921a8).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #16237      +/-   ##
============================================
+ Coverage     71.94%   72.05%   +0.10%     
- Complexity    64612    64802     +190     
============================================
  Files          5298     5303       +5     
  Lines        301952   302479     +527     
  Branches      43627    43699      +72     
============================================
+ Hits         217247   217937     +690     
+ Misses        66884    66649     -235     
- Partials      17821    17893      +72     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no any reason to downgrade the TLS client protocols below TLSv1.2, we should add TLSv1.3 instead:

systemProp.jdk.tls.client.protocols=TLSv1.2,TLSv1.3

Signed-off-by: Craig Perkins <[email protected]>
@cwperks
Copy link
Member Author

cwperks commented Oct 8, 2024

There are no any reason to downgrade the TLS client protocols below TLSv1.2, we should add TLSv1.3 instead:

systemProp.jdk.tls.client.protocols=TLSv1.2,TLSv1.3

Added TLSv1.3 in.

@cwperks cwperks changed the title Remove force to TLSv1.2 in gradle.properties Add TLSv1.3 in jdk.tls.client.protocols systemProp in gradle.properties Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

✅ Gradle check result for da921a8: SUCCESS

@reta reta added skip-changelog backport 2.x Backport to 2.x branch labels Oct 8, 2024
@reta reta merged commit febbc00 into opensearch-project:main Oct 8, 2024
42 of 44 checks passed
@reta
Copy link
Collaborator

reta commented Oct 8, 2024

Thanks @cwperks !

opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 8, 2024
…es (#16237)

* Remove force to TLSv1.2 in gradle.properties

Signed-off-by: Craig Perkins <[email protected]>

* Add TLSv1.3

Signed-off-by: Craig Perkins <[email protected]>

---------

Signed-off-by: Craig Perkins <[email protected]>
(cherry picked from commit febbc00)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Oct 8, 2024
…es (#16237) (#16239)

* Remove force to TLSv1.2 in gradle.properties



* Add TLSv1.3



---------


(cherry picked from commit febbc00)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants