Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated nomenclature to differentiate between hot and warm tiering implementation. #17490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Updated nomenclature to differentiate between hot and warm tiering implementation. #17490

wants to merge 2 commits into from
+64 −45

Conversation

mayanksharma27
Copy link

Description

  • We currently only have tiering implementation for warm indices.
  • The current nomenclature for feature flags and settings are too generic and cant differentiate between hot and warm indices.
  • Since we want to implement tiering for hot indices as well in near future; we would want to update the nomenclature to be extensible and easy to understand, this PR present the nomenclature changes.

Related Issues

Resolves #[17489]

Meta Issue #13149

Check List

  • [NA] Functionality includes testing.
  • [NA ] API changes companion pull request created, if applicable.
  • [NA] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e920df4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Feb 28, 2025
Open
mayanksharma27 pushed a commit to mayanksharma27/OpenSearch that referenced this pull request Mar 4, 2025
Addressed comments for PR opensearch-project#17490
38cf2ad 
Signed-off-by: Mayank Sharma <[email protected]>
mayanksharma27
mayanksharma27 commented Mar 4, 2025
View reviewed changes
Copy link
Author

@mayanksharma27 mayanksharma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed comments from @gbbafna

mayanksharma27 pushed a commit to mayanksharma27/OpenSearch that referenced this pull request Mar 5, 2025
Addressed comments for PR opensearch-project#17490
7ded36e 
Signed-off-by: Mayank Sharma <[email protected]>
mayanksharma27 pushed a commit to mayanksharma27/OpenSearch that referenced this pull request Mar 5, 2025
Updated settings from "index.is.warm" to "index.warm" as part of PR c…
bcc60a7 
…omments opensearch-project#17490

Signed-off-by: Mayank Sharma <[email protected]>
@mayanksharma27
Copy link
Author

Flaky ITs failing because of issue tracked here -#14294

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

❌ Gradle check result for c8b81e9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

❌ Gradle check result for 1cf82ee: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mayanksharma27
Copy link
Author

Current gradle check(https://build.ci.opensearch.org/job/gradle-check/54180/) failures due to flaky #11037

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025

❌ Gradle check result for a8acd81: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

mayanksharma27 pushed a commit to mayanksharma27/OpenSearch that referenced this pull request Mar 6, 2025
Addressed comments for PR opensearch-project#17490
972f8cd 
Signed-off-by: Mayank Sharma <[email protected]>
mayanksharma27 pushed a commit to mayanksharma27/OpenSearch that referenced this pull request Mar 6, 2025
Updated settings from "index.is.warm" to "index.warm" as part of PR c…
c43504c 
…omments opensearch-project#17490

Signed-off-by: Mayank Sharma <[email protected]>
mayanksharma27 pushed a commit to mayanksharma27/OpenSearch that referenced this pull request Mar 6, 2025
Addressed comments for PR opensearch-project#17490
724b934 
Signed-off-by: Mayank Sharma <[email protected]>
mayanksharma27 pushed a commit to mayanksharma27/OpenSearch that referenced this pull request Mar 6, 2025
Updated settings from "index.is.warm" to "index.warm" as part of PR c…
795936a 
…omments opensearch-project#17490

Signed-off-by: Mayank Sharma <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

❌ Gradle check result for d18bd6e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

✅ Gradle check result for 5552edd: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.49%. Comparing base (82bbdfb) to head (5552edd).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...c/main/java/org/opensearch/index/IndexService.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #17490      +/-   ##
============================================
- Coverage     72.59%   72.49%   -0.10%     
+ Complexity    65798    65792       -6     
============================================
  Files          5311     5311              
  Lines        304888   304887       -1     
  Branches      44212    44212              
============================================
- Hits         221323   221033     -290     
- Misses        65501    65805     +304     
+ Partials      18064    18049      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mayanksharma27 pushed a commit to mayanksharma27/OpenSearch that referenced this pull request Mar 6, 2025
Updated nomenclature to differentiate between current tiering impleme…
9cdec49 
…ntation for warm and upcoming hot implementation

commit 5552edd
Author: Mayank Sharma <[email protected]>
Date:   Thu Mar 6 16:38:38 2025 +0530

    Empty commit to rerun flaky test

    Signed-off-by: Mayank Sharma <[email protected]>

commit d18bd6e
Author: Mayank Sharma <[email protected]>
Date:   Thu Mar 6 14:25:33 2025 +0530

    Ran spotlessapply

    Signed-off-by: Mayank Sharma <[email protected]>

commit d5ac854
Author: Mayank Sharma <[email protected]>
Date:   Wed Mar 5 19:59:05 2025 +0530

    Empty commit to rerun flaky test

    Signed-off-by: Mayank Sharma <[email protected]>

commit 44000ee
Author: Mayank Sharma <[email protected]>
Date:   Wed Mar 5 19:17:00 2025 +0530

    Fixed failing UTs for ShardsTieringAllocationTests

    Signed-off-by: Mayank Sharma <[email protected]>

commit 03a9305
Author: Mayank Sharma <[email protected]>
Date:   Wed Mar 5 17:54:33 2025 +0530

    Empty commit to rerun flaky test

    Signed-off-by: Mayank Sharma <[email protected]>

commit 795936a
Author: Mayank Sharma <[email protected]>
Date:   Wed Mar 5 12:10:18 2025 +0530

    Updated settings from "index.is.warm" to "index.warm" as part of PR comments opensearch-project#17490

    Signed-off-by: Mayank Sharma <[email protected]>

commit 724b934
Author: Mayank Sharma <[email protected]>
Date:   Tue Mar 4 17:09:19 2025 +0530

    Addressed comments for PR opensearch-project#17490

    Signed-off-by: Mayank Sharma <[email protected]>

commit f1a249f
Author: Mayank Sharma <[email protected]>
Date:   Fri Feb 28 19:02:24 2025 +0530

    Updated nomenclature to differentiate between current tiering implementation for warm and upcoming hot implementation

    Signed-off-by: Mayank Sharma <[email protected]>

Signed-off-by: Mayank Sharma <[email protected]>
Added Warm setting and Updated nomenclature to differentiate between …
3c323e2 
…current tiering implementation for warm and upcoming hot implementation

commit 9cdec49
Author: Mayank Sharma <[email protected]>
Date:   Thu Mar 6 18:04:16 2025 +0530

    Updated nomenclature to differentiate between current tiering implementation for warm and upcoming hot implementation

    commit 5552edd
    Author: Mayank Sharma <[email protected]>
    Date:   Thu Mar 6 16:38:38 2025 +0530

        Empty commit to rerun flaky test

        Signed-off-by: Mayank Sharma <[email protected]>

    commit d18bd6e
    Author: Mayank Sharma <[email protected]>
    Date:   Thu Mar 6 14:25:33 2025 +0530

        Ran spotlessapply

        Signed-off-by: Mayank Sharma <[email protected]>

    commit d5ac854
    Author: Mayank Sharma <[email protected]>
    Date:   Wed Mar 5 19:59:05 2025 +0530

        Empty commit to rerun flaky test

        Signed-off-by: Mayank Sharma <[email protected]>

    commit 44000ee
    Author: Mayank Sharma <[email protected]>
    Date:   Wed Mar 5 19:17:00 2025 +0530

        Fixed failing UTs for ShardsTieringAllocationTests

        Signed-off-by: Mayank Sharma <[email protected]>

    commit 03a9305
    Author: Mayank Sharma <[email protected]>
    Date:   Wed Mar 5 17:54:33 2025 +0530

        Empty commit to rerun flaky test

        Signed-off-by: Mayank Sharma <[email protected]>

    commit 795936a
    Author: Mayank Sharma <[email protected]>
    Date:   Wed Mar 5 12:10:18 2025 +0530

        Updated settings from "index.is.warm" to "index.warm" as part of PR comments opensearch-project#17490

        Signed-off-by: Mayank Sharma <[email protected]>

    commit 724b934
    Author: Mayank Sharma <[email protected]>
    Date:   Tue Mar 4 17:09:19 2025 +0530

        Addressed comments for PR opensearch-project#17490

        Signed-off-by: Mayank Sharma <[email protected]>

    commit f1a249f
    Author: Mayank Sharma <[email protected]>
    Date:   Fri Feb 28 19:02:24 2025 +0530

        Updated nomenclature to differentiate between current tiering implementation for warm and upcoming hot implementation

        Signed-off-by: Mayank Sharma <[email protected]>

    Signed-off-by: Mayank Sharma <[email protected]>

Signed-off-by: Mayank Sharma <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2025

❌ Gradle check result for 3c323e2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@mayanksharma27
Copy link
Author

Flaky integ tests failing - #11037

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Mar 7, 2025
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 33f94d1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e6e82ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 33f94d1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@cwperks cwperks Awaiting requested review from cwperks cwperks is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@jed326 jed326 Awaiting requested review from jed326 jed326 is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@bugmakerrrrrr bugmakerrrrrr Awaiting requested review from bugmakerrrrrr bugmakerrrrrr is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

@peternied peternied Awaiting requested review from peternied

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mayanksharma27 @gbbafna