Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codec compare in shouldUpgrade method of OpenSearchMergePolicy #17491

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

MrChaos1993
Copy link

@MrChaos1993 MrChaos1993 commented Feb 28, 2025

Description

Allow to use UpgradeRequest to change codecs.

Related Issues

Related to description in #13569

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@MrChaos1993 MrChaos1993 force-pushed the feat/compare-codecs-in-upgrade branch 2 times, most recently from dfae534 to e2f2630 Compare February 28, 2025 14:28
Copy link
Contributor

❌ Gradle check result for e2f2630: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@MrChaos1993 MrChaos1993 force-pushed the feat/compare-codecs-in-upgrade branch 3 times, most recently from ab8eebc to cf087bd Compare March 5, 2025 11:13
Copy link
Contributor

github-actions bot commented Mar 5, 2025

❌ Gradle check result for cf087bd: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@MrChaos1993 MrChaos1993 force-pushed the feat/compare-codecs-in-upgrade branch from cf087bd to e0dc807 Compare March 5, 2025 11:38
Copy link
Contributor

github-actions bot commented Mar 5, 2025

❌ Gradle check result for e0dc807: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@MrChaos1993 MrChaos1993 force-pushed the feat/compare-codecs-in-upgrade branch from 40340a9 to 8f7be3a Compare March 5, 2025 12:25
Copy link
Contributor

github-actions bot commented Mar 5, 2025

❌ Gradle check result for 8f7be3a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@MrChaos1993 MrChaos1993 force-pushed the feat/compare-codecs-in-upgrade branch from 8f7be3a to 393c257 Compare March 5, 2025 12:53
Copy link
Contributor

github-actions bot commented Mar 5, 2025

❕ Gradle check result for 393c257: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 72.39%. Comparing base (ffa46ca) to head (7951dda).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
.../opensearch/index/shard/OpenSearchMergePolicy.java 66.66% 1 Missing and 3 partials ⚠️
...lucene90/Lucene90StoredFieldsFormatComparator.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17491      +/-   ##
============================================
- Coverage     72.43%   72.39%   -0.04%     
+ Complexity    65721    65704      -17     
============================================
  Files          5311     5312       +1     
  Lines        304941   304951      +10     
  Branches      44228    44232       +4     
============================================
- Hits         220890   220778     -112     
- Misses        65952    66111     +159     
+ Partials      18099    18062      -37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrChaos1993 MrChaos1993 force-pushed the feat/compare-codecs-in-upgrade branch from 393c257 to 9444805 Compare March 12, 2025 08:00
Copy link
Contributor

❌ Gradle check result for 9444805: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Aleksandr Tuliakov <[email protected]>
@MrChaos1993 MrChaos1993 force-pushed the feat/compare-codecs-in-upgrade branch from 9444805 to 7951dda Compare March 12, 2025 09:20
Copy link
Contributor

❕ Gradle check result for 7951dda: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.snapshots.DedicatedClusterSnapshotRestoreIT.testSnapshotWithStuckNode

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant