-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add adaptive merge policy to reduce benchmark variance #19352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Gradle check result for 2b398ff: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
2b398ff
to
e88f69b
Compare
❌ Gradle check result for abe1e49: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
abe1e49
to
5076ee5
Compare
❌ Gradle check result for 5076ee5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
5076ee5
to
6f0df5f
Compare
❌ Gradle check result for 6f0df5f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 52b76ce: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
52b76ce
to
0f6473e
Compare
❌ Gradle check result for 0f6473e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for f384695: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
f384695
to
3d0444b
Compare
❌ Gradle check result for 3d0444b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for b7454b9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
b7454b9
to
f3d7ad7
Compare
❌ Gradle check result for f3d7ad7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 9a7f377: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 96ba35e: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
96ba35e
to
69db21b
Compare
❌ Gradle check result for 69db21b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e4e9362
to
c5a14ad
Compare
❌ Gradle check result for c5a14ad: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sriram Ganesh <[email protected]> Fixed the style check issues Signed-off-by: Sriram Ganesh <[email protected]> Fixed javadocs Signed-off-by: Sriram Ganesh <[email protected]> Refactored the code Signed-off-by: Sriram Ganesh <[email protected]> Changed the api version Signed-off-by: Sriram Ganesh <[email protected]> Refactored the code Signed-off-by: Sriram Ganesh <[email protected]> Refactored the code Signed-off-by: Sriram Ganesh <[email protected]> Refactored the code Signed-off-by: Sriram Ganesh <[email protected]> Resolved stylecheck issues. Signed-off-by: Sriram Ganesh <[email protected]> Refactored the code Signed-off-by: Sriram Ganesh <[email protected]>
❌ Gradle check result for dc91796: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sriram Ganesh <[email protected]>
❕ Gradle check result for 97148d6: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19352 +/- ##
============================================
- Coverage 73.08% 72.91% -0.17%
+ Complexity 70491 70413 -78
============================================
Files 5712 5715 +3
Lines 322762 323040 +278
Branches 46743 46769 +26
============================================
- Hits 235879 235541 -338
- Misses 67941 68504 +563
- Partials 18942 18995 +53 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@msfroh - Could you please review this PR? |
Description
Introduced an adaptive merge policy system in OpenSearch that dynamically tunes Lucene segment merge settings based on shard size. The solution replaces static defaults with context-aware configurations, improving benchmark consistency and search performance across varying index sizes. Key additions include an
AdaptiveTieredMergePolicyProvider
for shard-specific optimisations, aSegmentTopologyAnalyzer
for segment distribution analysis, and a REST API for real-time monitoring. This change delivers more predictable performance and optimised search behaviour for users.Related Issues
Resolves #11163
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.