-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Fix Unified highlighter for nested fields when using matchPhrasePrefixQuery #19442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix Unified highlighter for nested fields when using matchPhrasePrefixQuery #19442
Conversation
❌ Gradle check result for d61fbdb: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
d61fbdb
to
bc6deeb
Compare
❌ Gradle check result for 17794cc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
3f1e99c
to
708767d
Compare
…xQuery Signed-off-by: sjs004 <[email protected]>
708767d
to
739a4b9
Compare
❕ Gradle check result for 739a4b9: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19442 +/- ##
============================================
+ Coverage 72.93% 73.01% +0.07%
- Complexity 70236 70288 +52
============================================
Files 5700 5700
Lines 322150 322152 +2
Branches 46616 46617 +1
============================================
+ Hits 234966 235206 +240
+ Misses 68225 67955 -270
- Partials 18959 18991 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Description
CustomUnifiedHighlighter.rewriteCustomQuery() wasn't handling nested query (internally written as OpenSearchToParentBlockJoinQuery). Therefore unified highlighter wasn't working. Added the missing handling & updated tests
Related Issues
Resolves #19106
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.