Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix error handling while reading analyzer mapping rules #5125

Closed
wants to merge 1 commit into from
Closed

[Backport 2.x] Fix error handling while reading analyzer mapping rules #5125

wants to merge 1 commit into from

Conversation

adnapibar
Copy link
Contributor

backport 6d20423 to 2.x

Signed-off-by: Rabi Panda [email protected]

Description

Add new parseWordList method that takes a parser as a parameter. It reads custom rules from settings or a file, parses and handles errors. Make error messages less verbose for rules files outside config directory.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Add new parseWordList method that takes a parser as a parameter. It reads custom rules from settings or a file, parses and handles errors. Make error messages less verbose for rules files outside config directory.

Signed-off-by: Rabi Panda <[email protected]>
@adnapibar adnapibar requested review from a team and reta as code owners November 8, 2022 02:20
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

@adnapibar
Copy link
Contributor Author

This change is also going to 2.4, should we update the CHANGELOG for 2.x ?

@andrross andrross added skip-changelog backport PRs or issues specific to backporting features or enhancments autocut and removed backport PRs or issues specific to backporting features or enhancments labels Nov 8, 2022
@andrross
Copy link
Member

andrross commented Nov 8, 2022

This change is also going to 2.4, should we update the CHANGELOG for 2.x ?

You did the right thing here. I have a PR out now to provide some updated instructions here. Soon the skip-changelog label will work when we don't need to add a changelog entry. (for now I used autocut which has the same effect)

@dblock
Copy link
Member

dblock commented Nov 8, 2022

Build is failing on something new, #5121, looks like an artifact was expired/yanked from maven (?), @mch2 is on it.

@dblock
Copy link
Member

dblock commented Nov 8, 2022

Rebase this - the nebula problem should be fixed. Let’s make sure this passes all CI.

Trying to get a passing build in #5142.

@dblock
Copy link
Member

dblock commented Nov 8, 2022

Merged via #5142.

@dblock dblock closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants