Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [Refactor] Version and LegacyESVersion from server module to core lib (#7328) #8382

Merged

Conversation

nknize
Copy link
Collaborator

@nknize nknize commented Jun 30, 2023

Backport 142ae46 from #7328.

relates #7818

@nknize nknize added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments v2.9.0 'Issues and PRs related to version v2.9.0' labels Jun 30, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@nknize
Copy link
Collaborator Author

nknize commented Jun 30, 2023

Unrelated CI/CD failure. Documented on #8352 (comment)

refiring

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      2 org.opensearch.search.SearchWeightedRoutingIT.testStrictWeightedRoutingWithCustomString
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testPitCreatedOnReplica
      1 org.opensearch.remotestore.RemoteStoreRefreshListenerIT.testRemoteRefreshRetryOnFailure
      1 org.opensearch.remotestore.CreateRemoteIndexIT.testRemoteStoreTranslogDisabledByUser
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testBasicTaskResourceTracking

@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #8382 (caabc00) into 2.x (9b9718f) will increase coverage by 0.11%.
The diff coverage is 82.55%.

@@             Coverage Diff              @@
##                2.x    #8382      +/-   ##
============================================
+ Coverage     70.47%   70.58%   +0.11%     
- Complexity    56953    57017      +64     
============================================
  Files          4737     4737              
  Lines        270103   270094       -9     
  Branches      39905    39901       -4     
============================================
+ Hits         190345   190638     +293     
+ Misses        63404    63065     -339     
- Partials      16354    16391      +37     
Impacted Files Coverage Δ
.../opensearch/gradle/info/GlobalBuildInfoPlugin.java 38.46% <0.00%> (ø)
libs/core/src/main/java/org/opensearch/Build.java 66.66% <ø> (ø)
.../src/main/java/org/opensearch/LegacyESVersion.java 81.66% <0.00%> (ø)
...ibs/core/src/main/java/org/opensearch/Version.java 84.00% <0.00%> (ø)
...admin/indices/upgrade/post/ShardUpgradeResult.java 0.00% <0.00%> (ø)
...on/admin/indices/upgrade/post/UpgradeResponse.java 0.00% <0.00%> (ø)
...n/indices/upgrade/post/UpgradeSettingsRequest.java 0.00% <0.00%> (ø)
.../main/java/org/opensearch/env/NodeEnvironment.java 76.62% <ø> (-1.12%) ⬇️
...rg/opensearch/index/translog/RemoteFsTranslog.java 71.50% <ø> (+1.11%) ⬆️
...in/java/org/opensearch/indices/IndicesService.java 69.44% <ø> (-0.76%) ⬇️
... and 28 more

... and 486 files with indirect coverage changes

…opensearch-project#7328)

Refactors the Version and LegacyESVersion classes from the server module
to the core library. All gradle build scripts and dependencies are
updated. This commit serves as a foundation for refactoring all
OpenSearch base classes from the server module into appropriate
libraries to decouple core search logic from the cluster model so
it can be reused in serverless and cloud native environments.

Signed-off-by: Nicholas Walter Knize <[email protected]>
@nknize
Copy link
Collaborator Author

nknize commented Jul 5, 2023

/cc @andrross

I need these reviewed so I can finish the remaining backports. Downstreams never kept up with the incremental changes on main so they have PRs that conflate these changes. e.g., see opensearch-project/ml-commons#901 (comment)

@nknize nknize force-pushed the backport/backport-7328-to-2.x branch from 5009859 to caabc00 Compare July 5, 2023 17:02
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteStoreBackpressureIT.testWritesRejectedDueToTimeLagBreach

@andrross andrross merged commit 876dd16 into opensearch-project:2.x Jul 5, 2023
8 checks passed
@b4sjoo
Copy link

b4sjoo commented Jul 6, 2023

@nknize I just wonder if eventually all Strings related methods will refactor to core lib, or if they are not refactored now, they will keep staying in their original library for a while?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PRs or issues specific to backporting features or enhancments enhancement Enhancement or improvement to existing feature or request v2.9.0 'Issues and PRs related to version v2.9.0'
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants