Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change noisy logs on SegRep and remote store paths to trace level #9323

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Change noisy logs on SegRep and remote store paths to trace level #9323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions server/src/main/java/org/opensearch/index/shard/IndexShard.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1641,20 +1641,20 @@
*/
public boolean isSegmentReplicationAllowed() {
if (indexSettings.isSegRepEnabled() == false) {
logger.warn("Attempting to perform segment replication when it is not enabled on the index");
logger.trace("Attempting to perform segment replication when it is not enabled on the index");
return false;
}
if (getReplicationTracker().isPrimaryMode()) {
logger.warn("Shard is in primary mode and cannot perform segment replication as a replica.");
logger.trace("Shard is in primary mode and cannot perform segment replication as a replica.");

Check warning on line 1648 in server/src/main/java/org/opensearch/index/shard/IndexShard.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/shard/IndexShard.java#L1648 

Added line #L1648 was not covered by tests
return false;
}
if (this.routingEntry().primary()) {
logger.warn("Shard routing is marked primary thus cannot perform segment replication as replica");
logger.trace("Shard routing is marked primary thus cannot perform segment replication as replica");

Check warning on line 1652 in server/src/main/java/org/opensearch/index/shard/IndexShard.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/shard/IndexShard.java#L1652 

Added line #L1652 was not covered by tests
return false;
}
if (state().equals(IndexShardState.STARTED) == false
&& (state() == IndexShardState.POST_RECOVERY && shardRouting.state() == ShardRoutingState.INITIALIZING) == false) {
logger.warn(
logger.trace(
() -> new ParameterizedMessage(
"Shard is not started or recovering {} {} and cannot perform segment replication as a replica",
state(),
Expand All @@ -1664,7 +1664,7 @@
return false;
}
if (getReplicationEngine().isEmpty()) {
logger.warn(
logger.trace(

Check warning on line 1667 in server/src/main/java/org/opensearch/index/shard/IndexShard.java

View check run for this annotation

Codecov / codecov/patch

server/src/main/java/org/opensearch/index/shard/IndexShard.java#L1667 

Added line #L1667 was not covered by tests
dreamer-89 marked this conversation as resolved.
Show resolved Hide resolved
() -> new ParameterizedMessage(
"Shard does not have the correct engine type to perform segment replication {}.",
getEngine().getClass()
Expand Down Expand Up @@ -4815,8 +4815,8 @@
}
}
} finally {
logger.info("Downloaded segments here: {}", downloadedSegments);
logger.info("Skipped download for segments here: {}", skippedSegments);
logger.trace("Downloaded segments here: {}", downloadedSegments);
logger.trace("Skipped download for segments here: {}", skippedSegments);
}
return segmentNFile;
}
Expand Down
2 changes: 1 addition & 1 deletion server/src/main/java/org/opensearch/index/shard/RemoteStoreRefreshListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ private boolean shouldSync(boolean didRefresh) {

private boolean syncSegments() {
if (indexShard.getReplicationTracker().isPrimaryMode() == false || indexShard.state() == IndexShardState.CLOSED) {
logger.info(
logger.trace(
"Skipped syncing segments with primaryMode={} indexShardState={}",
indexShard.getReplicationTracker().isPrimaryMode(),
indexShard.state()
Expand Down
6 changes: 3 additions & 3 deletions server/src/main/java/org/opensearch/index/store/RemoteSegmentStoreDirectory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public RemoteSegmentMetadata readLatestMetadataFile() throws IOException {
logger.trace("Reading latest Metadata file {}", latestMetadataFile);
remoteSegmentMetadata = readMetadataFile(latestMetadataFile);
} else {
logger.info("No metadata file found, this can happen for new index with no data uploaded to remote segment store");
logger.trace("No metadata file found, this can happen for new index with no data uploaded to remote segment store");
}

return remoteSegmentMetadata;
Expand Down Expand Up @@ -786,7 +786,7 @@ public void deleteStaleSegments(int lastNMetadataFilesToKeep) throws IOException
Integer.MAX_VALUE
);
if (sortedMetadataFileList.size() <= lastNMetadataFilesToKeep) {
logger.info(
logger.trace(
"Number of commits in remote segment store={}, lastNMetadataFilesToKeep={}",
sortedMetadataFileList.size(),
lastNMetadataFilesToKeep
Expand Down Expand Up @@ -849,7 +849,7 @@ public void deleteStaleSegments(int lastNMetadataFilesToKeep) throws IOException
}
});
if (deletionSuccessful.get()) {
logger.info("Deleting stale metadata file {} from remote segment store", metadataFile);
logger.trace("Deleting stale metadata file {} from remote segment store", metadataFile);
remoteMetadataDirectory.deleteFile(metadataFile);
}
}
Expand Down
Loading