Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Fix Duplicate Scheduling of Index Rollover in ADIndexManagement #1233

Merged
merged 1 commit into from
Jun 10, 2024
Merged

[Backport 2.x] Fix Duplicate Scheduling of Index Rollover in ADIndexManagement #1233

merged 1 commit into from
Jun 10, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link

Backport 744a24f from #1231.

@github-actions
Fix Duplicate Scheduling of Index Rollover in ADIndexManagement (#1231)
a1e7c89 
ADIndexManagement inherits from IndexManagement, which implements LocalNodeClusterManagerListener, causing it to listen for master node changes. This listener schedules index rollover and deletion. However, ADIndexManagement was inadvertently listening to the cluster manager event again, leading to duplicate scheduling of these tasks.

This commit removes the redundant listener call in ADIndexManagement, ensuring that index rollover and deletion are scheduled only once per interval.

Testing:

Verified that index rollover and deletion now execute once per interval as expected.

Signed-off-by: Kaituo Li <[email protected]>
(cherry picked from commit 744a24f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kaituo
Copy link
Collaborator

kaituo commented Jun 10, 2024

windows CI failed due to

  • What went wrong:
    Could not determine the dependencies of task ':thirdPartyAudit'.

Could not resolve all files for configuration ':resolveableCompileOnly'.
Could not resolve org.opensearch.plugin:opensearch-scripting-painless-spi:2.15.0-SNAPSHOT.
Required by:
project :
> Could not resolve org.opensearch.plugin:opensearch-scripting-painless-spi:2.15.0-SNAPSHOT.
> Unable to load Maven meta-data from https://ci.opensearch.org/ci/dbc/snapshots/lucene/org/opensearch/plugin/opensearch-scripting-painless-spi/2.15.0-SNAPSHOT/maven-metadata.xml.
> Could not GET 'https://ci.opensearch.org/ci/dbc/snapshots/lucene/org/opensearch/plugin/opensearch-scripting-painless-spi/2.15.0-SNAPSHOT/maven-metadata.xml'. Received status code 403 from server: Forbidden

maybe because infra team build has issues. Will leave as it is.

@kaituo kaituo merged commit 71d47e4 into 2.x Jun 10, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaituo kaituo kaituo approved these changes

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@jngz-es jngz-es Awaiting requested review from jngz-es jngz-es is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@ohltyler ohltyler Awaiting requested review from ohltyler ohltyler is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn ylwu-amzn is a code owner

@amitgalitz amitgalitz Awaiting requested review from amitgalitz amitgalitz is a code owner

@jackiehanyang jackiehanyang Awaiting requested review from jackiehanyang jackiehanyang is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@joshpalis joshpalis Awaiting requested review from joshpalis joshpalis is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kaituo