Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates admin credentials used in github workflow #518

Closed

Conversation

DarshitChanpura
Copy link
Member

Description

This PR updates the occurrences of admin password in the github workflows. Coming from opensearch-project/security#3624, the security plugin recently introduced a change to require a custom strong password to be supplied when setting up the admin user via demo configuration.

Issues Resolved

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@RS146BIJAY RS146BIJAY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is one change in even README.md and build.gradle as well.

@DarshitChanpura
Copy link
Member Author

updated all instances of admin credentials. This change should not be backported to <2.12 since the admin password changes are not required in those versions.

@DarshitChanpura
Copy link
Member Author

Build failure seems to be unrelated:

* What went wrong:
A problem occurred configuring root project 'asynchronous-search'.
> java.util.concurrent.ExecutionException: org.gradle.api.GradleException: Failed to create Jar file /home/ci-runner/.gradle/caches/jars-9/6abf203a3d0[29](https://github.com/opensearch-project/asynchronous-search/actions/runs/7645086127/job/20830851711?pr=518#step:5:30)0f2fc6dc41dd82cb00d/jackson-core-2.16.1.jar.

@bharath-techie
Copy link
Collaborator

Hi @DarshitChanpura ,
Thanks for the changes.

We needed another change which include 2.12 BWC jar to make the build pass, so we had to raise a new PR and merge the changes.

Closing this PR for now.

@DarshitChanpura
Copy link
Member Author

DarshitChanpura commented Jan 25, 2024

Sounds good @bharath-techie . The PR: #521
added a duplicate line in README that could be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport to 2.x v2.12.0 Issues targeting release v2.12.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v2.12.0] Ensure CI/documentation reflect changes to default admin credentials
3 participants