Standardize build/test github actions and java versions #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnegancarroll
requested review from
Bukhtawar,
bharath-techie,
Arpit-Bandejiya,
RS146BIJAY,
pranikum,
mch2,
andrross,
kotwanikunal and
Rishikesh1159
as code owners
finnegancarroll
changed the title
|
@finnegancarroll This largely looks right to me, but i am not sure why this PR did not run the test & build workflows? Is this related to your update? |
mch2
reviewed
Sep 17, 2024
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
…p actions to @V3. Workflows run directly on runners already have up to date glibc. Signed-off-by: Finn Carroll <[email protected]>
Signed-off-by: Finn Carroll <[email protected]>
…atibility java 21 Signed-off-by: Finn Carroll <[email protected]>
finnegancarroll
force-pushed
the
java21build
branch
from
76ff633
to
825abab
Compare
|
Moved all workflows to java 21 only. Per https://github.com/opensearch-project/asynchronous-search/blob/main/build.gradle#L84 java 21 is the minimal compatible version on main. |
mch2
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove hard coded java versions - use java.matrix instead so we can easily add and remove java versions for each workflow. Build/publish/release with all supported versions - 11/17/21. Test only with java 21.
Standardize version of github actions:
actions/setup-java to v4
actions/checkout to v4
For containerized workflows the image published by opensearch-build does not have a high enough version of glibc to support these v4 actions. Here we downgrade to v3 which only needs node 16 and set `ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true.
Related Issues
Should fix publish failure with java upgrade for that workflow: 11 -> 21.
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.