Enable cypress test for windows and mac platform #91
Conversation
heemin32
force-pushed
the
cypress
branch
2 times, most recently
from
ca860a6
to
13a78fb
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #91 +/- ##
=======================================
Coverage 85.03% 85.03%
=======================================
Files 5 5
Lines 147 147
Branches 24 24
=======================================
Hits 125 125
Misses 16 16
Partials 6 6 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
heemin32
force-pushed
the
cypress
branch
18 times, most recently
from
cf50bf4
to
1033c22
Compare
Signed-off-by: Heemin Kim <[email protected]>
|
I had to increase timeout values and reduce sample_geojson.json file so that cypress tests in windows to pass. |
Yes. Will forward port it once it is approved. |
| - name: Run Cypress tests | ||
| uses: cypress-io/github-action@v2 | ||
| with: | ||
| working-directory: OpenSearch-Dashboards/plugins/custom_import_map | ||
| command: yarn run cypress run | ||
| command: yarn run cypress run --browser chrome |
There was a problem hiding this comment.
why we are sticking to chrome here? Should we test on multiple browsers? Does OSD has some recommendation?
There was a problem hiding this comment.
OSD uses chrome as default. https://github.com/opensearch-project/opensearch-dashboards-functional-test/blob/main/.github/workflows/cypress-workflow-bundle-snapshot-based-windows.yml#L31
Haven't checked every plugins but I know some plugins also have chrome as a default browser.
|
Please forward port this change to the main branch. |
Signed-off-by: Heemin Kim [email protected]
Description
Enable cypress test for windows and mac platform
Issues Resolved
#55
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.