Improve wording for TLS-related options #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smortex
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90 and
praveensameneni
as code owners
smortex
force-pushed
the
tls-wording
branch
2 times, most recently
from
ee85ca1
to
3105b51
Compare
|
@Hailong-am one of the failing CI seems to be a transient error but the other one is caused by me who missed the test 😶. I fixed my commit and force-pushed. Ready for another CI run! |
Codecov Report
@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage 86.70% 86.70%
=======================================
Files 52 52
Lines 1497 1497
Branches 373 373
=======================================
Hits 1298 1298
Misses 196 196
Partials 3 3
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Hum, not sure I am reading the windows failure log correctly: I feel like the errors logged on each test of some components are JS errors which can be ignored because the test pass (the errors are logged after the test result is displayed?): But I can't identify the actual failure in the log. The following looks like a good candidate but some test setup failure but lacks details: |
O |
Hailong-am
approved these changes
Sep 25, 2023
|
@smortex would you mind update |
When configuring a SMTP sender, the user is prompted for an "Encryption method" and given a drop-down list to choose from. The list currently contain "SSL", "TLS" and "None" which is a bit confusing given that TLS is built on deprecated SSL and both refer to the same thing. In this list, "SSL" actually mean TLS, and "TLS" actually mean StartTLS (aka Opportunistic TLS). Adjust wording to wake this more obvious. The new wording match the one used in Thunderbird when configuring connection security. Signed-off-by: Romain Tartière <[email protected]>
smortex
force-pushed
the
tls-wording
branch
from
3105b51
to
2d63e5f
Compare
|
@Hailong-am done! |
|
Have separate PR to fix windows platform test #118 |
yuye-aws
approved these changes
Sep 26, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 26, 2023
When configuring a SMTP sender, the user is prompted for an "Encryption method" and given a drop-down list to choose from. The list currently contain "SSL", "TLS" and "None" which is a bit confusing given that TLS is built on deprecated SSL and both refer to the same thing. In this list, "SSL" actually mean TLS, and "TLS" actually mean StartTLS (aka Opportunistic TLS). Adjust wording to wake this more obvious. The new wording match the one used in Thunderbird when configuring connection security. Signed-off-by: Romain Tartière <[email protected]> (cherry picked from commit 2506331) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
yuye-aws
pushed a commit
that referenced
this pull request
Sep 27, 2023
When configuring a SMTP sender, the user is prompted for an "Encryption method" and given a drop-down list to choose from. The list currently contain "SSL", "TLS" and "None" which is a bit confusing given that TLS is built on deprecated SSL and both refer to the same thing. In this list, "SSL" actually mean TLS, and "TLS" actually mean StartTLS (aka Opportunistic TLS). Adjust wording to wake this more obvious. The new wording match the one used in Thunderbird when configuring connection security. (cherry picked from commit 2506331) Signed-off-by: Romain Tartière <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Sep 27, 2023
When configuring a SMTP sender, the user is prompted for an "Encryption method" and given a drop-down list to choose from. The list currently contain "SSL", "TLS" and "None" which is a bit confusing given that TLS is built on deprecated SSL and both refer to the same thing. In this list, "SSL" actually mean TLS, and "TLS" actually mean StartTLS (aka Opportunistic TLS). Adjust wording to wake this more obvious. The new wording match the one used in Thunderbird when configuring connection security. (cherry picked from commit 2506331) Signed-off-by: Romain Tartière <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 61ceae1)
yuye-aws
pushed a commit
that referenced
this pull request
Sep 28, 2023
When configuring a SMTP sender, the user is prompted for an "Encryption method" and given a drop-down list to choose from. The list currently contain "SSL", "TLS" and "None" which is a bit confusing given that TLS is built on deprecated SSL and both refer to the same thing. In this list, "SSL" actually mean TLS, and "TLS" actually mean StartTLS (aka Opportunistic TLS). Adjust wording to wake this more obvious. The new wording match the one used in Thunderbird when configuring connection security. (cherry picked from commit 2506331) Signed-off-by: Romain Tartière <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> (cherry picked from commit 61ceae1) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When configuring a SMTP sender, the user is prompted for an "Encryption method" and given a drop-down list to choose from. The list currently contain "SSL", "TLS" and "None" which is a bit confusing given that TLS is built on deprecated SSL and both refer to the same thing.
In this list, "SSL" actually mean TLS, and "TLS" actually mean StartTLS (aka Opportunistic TLS).
Adjust wording to wake this more obvious. The new wording match the one used in Thunderbird when configuring connection security.