Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [navigation]feat: change parent item name #235

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 562d3a1 from #234.

* feat: change parent item name

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update title of entries

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: update link

Signed-off-by: SuZhou-Joe <[email protected]>

* feat: add description

Signed-off-by: SuZhou-Joe <[email protected]>

---------

Signed-off-by: SuZhou-Joe <[email protected]>
(cherry picked from commit 562d3a1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Collaborator

@AWSHurneyt AWSHurneyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving assuming CI passes.

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (7eadd8e) to head (1dddcbf).
Report is 16 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x     #235      +/-   ##
==========================================
- Coverage   86.57%   84.71%   -1.87%     
==========================================
  Files          52       54       +2     
  Lines        1497     1583      +86     
  Branches      373      416      +43     
==========================================
+ Hits         1296     1341      +45     
- Misses        198      239      +41     
  Partials        3        3              
Flag Coverage Δ
dashboards-notifications 84.71% <ø> (-1.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 2a3f96b into 2.x Aug 14, 2024
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants