[Backport 2.x] Persist dataSourceId across applications under new Nav change (#244) #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch-project#244) * Persist dataSourceId across applications under new Nav change Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fix UTs Signed-off-by: Riya Saxena <[email protected]> * moved to constants Signed-off-by: Riya Saxena <[email protected]> * revert changes in snapshot files Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit f209c40)
riysaxen-amzn
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
getsaurabh02,
sbcd90,
praveensameneni,
amsiglan and
AWSHurneyt
as code owners
AWSHurneyt
approved these changes
Sep 4, 2024
Signed-off-by: Riya <[email protected]>
amsiglan
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…249) * Persist dataSourceId across applications under new Nav change Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fix UTs Signed-off-by: Riya Saxena <[email protected]> * moved to constants Signed-off-by: Riya Saxena <[email protected]> * revert changes in snapshot files Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit f209c40) Signed-off-by: Riya <[email protected]> (cherry picked from commit 0bc8724)
riysaxen-amzn
added a commit
that referenced
this pull request
Sep 5, 2024
…249) (#255) * Persist dataSourceId across applications under new Nav change Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fixes with mds Signed-off-by: Riya Saxena <[email protected]> * fix UTs Signed-off-by: Riya Saxena <[email protected]> * moved to constants Signed-off-by: Riya Saxena <[email protected]> * revert changes in snapshot files Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> Co-authored-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit f209c40) Signed-off-by: Riya <[email protected]> (cherry picked from commit 0bc8724) Co-authored-by: Riya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Signed-off-by: Riya Saxena [email protected]
Co-authored-by: Amardeepsingh Siglani [email protected]
(cherry picked from commit f209c40)
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.