Bump browserify-sign to address CVE-2023-46234 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Ho <[email protected]>
derek-ho
requested review from
pjfitzgibbons,
ps48,
kavithacm,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az and
anirudha
as code owners
joshuali925
approved these changes
Nov 1, 2023
YANG-DB
approved these changes
Nov 1, 2023
joshuali925
reviewed
Nov 1, 2023
| version "4.1.0" | ||
| resolved "https://registry.yarnpkg.com/browserify-rsa/-/browserify-rsa-4.1.0.tgz#b2fd06b5b75ae297f7ce2dc651f918f5be158c8d" | ||
| integrity sha512-AdEER0Hkspgno2aR97SAf6vi0y0k8NuOpGnVH3O99rcA5Q6sh8QxcngtHuJ6uXwnfAXNM4Gn1Gb7/MV1+Ymbog== | ||
| dependencies: | ||
| bn.js "^5.0.0" | ||
| randombytes "^2.0.1" | ||
|
|
||
| browserify-sign@^4.0.0: |
There was a problem hiding this comment.
it was already ^4.0.0, no need to force resolve
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/dashboards-reporting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/dashboards-reporting/backport-2.x
# Create a new branch
git switch --create backport/backport-240-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a23dbbbf67c9e5399ee53ac910c3f9f019a845a6
# Push it to GitHub
git push --set-upstream origin backport/backport-240-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/dashboards-reporting/backport-2.xThen, create a pull request where the |
joshuali925
pushed a commit
to joshuali925/dashboards-reporting
that referenced
this pull request
Nov 1, 2023
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit a23dbbb)
mengweieric
pushed a commit
that referenced
this pull request
Nov 7, 2023
Signed-off-by: Derek Ho <[email protected]> (cherry picked from commit a23dbbb) Co-authored-by: Derek Ho <[email protected]>
|
backported here: #242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump browserify-sign to address CVE-2023-46234
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.