Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add Windows Support #16

Closed
1 of 2 tasks
Tracked by #95
bbarani opened this issue Oct 28, 2022 · 8 comments · Fixed by #39
Closed
1 of 2 tasks
Tracked by #95

[FEATURE] Add Windows Support #16

bbarani opened this issue Oct 28, 2022 · 8 comments · Fixed by #39
Labels
enhancement New feature or request v2.4.0

Comments

@bbarani
Copy link
Member

bbarani commented Oct 28, 2022

Coming from opensearch-project/opensearch-plugins#95, add Windows support.

  • Passing CI on Windows
  • Documentation
@macohen
Copy link
Collaborator

macohen commented Oct 28, 2022

Build failed on Windows. Added the following to the workflow, but it still failed.

- name: Check LongPathsEnabled
  if: ${{ matrix.os == 'windows-latest' }}
  run: |
     (Get-ItemProperty "HKLM:System\CurrentControlSet\Control\FileSystem").LongPathsEnabled

@peterzhuamazon, any ideas?

@macohen
Copy link
Collaborator

macohen commented Oct 28, 2022

One more question, this is an experimental feature in 2.4. Given that, must it work on Windows?

@bbarani
Copy link
Member Author

bbarani commented Oct 31, 2022

@macohen expectation is that any plugin on-boarded to 2.4.0 release should have working Windows CI on their repo to support that distribution going forward.

@dblock
Copy link
Member

dblock commented Nov 3, 2022

@macohen Are integration/cypress tests running on Windows, and/or are there any coverage differences between Linux and Windows tests? If yes, please reopen this issue until that gap is covered.

@msfroh
Copy link
Collaborator

msfroh commented Nov 3, 2022

@msfroh msfroh reopened this Nov 3, 2022
@msfroh
Copy link
Collaborator

msfroh commented Nov 3, 2022

(All of the other e2e testing workflows in opensearch-dashboards-functional-test seem to use ubuntu-latest as well, though.)

@macohen
Copy link
Collaborator

macohen commented Nov 8, 2022

builds pass CI for windows. we've been entirely focused on integ tests at this point. @bbarani What documentation are you looking for on this? Are there any examples?

@macohen
Copy link
Collaborator

macohen commented Nov 8, 2022

Windows CI is passing. Closing issue.

@macohen macohen closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request v2.4.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants