Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add windows-latest back to test-and-build workflow #39

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

msfroh
Copy link
Collaborator

@msfroh msfroh commented Nov 1, 2022

Set the git config for core.longpaths to "true" to enable long file paths on Windows, as that was blocking us from checking out OpenSearch-Dashboards.

Signed-off-by: Michael Froh [email protected]

Description

Fixes Windows build by enabling core.longpaths Git setting.

Issues Resolved

Closes #16

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Trying to set the git config for core.longpaths to "true" to enable
long file paths on Windows, as that was blocking us from checking out
OpenSearch-Dashboards.

Signed-off-by: Michael Froh <[email protected]>
@msfroh msfroh requested a review from macohen November 1, 2022 16:06
@msfroh msfroh self-assigned this Nov 1, 2022
@macohen macohen merged commit 713c9c8 into opensearch-project:main Nov 1, 2022
@macohen
Copy link
Collaborator

macohen commented Nov 1, 2022

Looks great! Thanks!

github-actions bot added a commit that referenced this pull request Nov 1, 2022
Trying to set the git config for core.longpaths to "true" to enable
long file paths on Windows, as that was blocking us from checking out
OpenSearch-Dashboards.

Signed-off-by: Michael Froh <[email protected]>

Signed-off-by: Michael Froh <[email protected]>
(cherry picked from commit 713c9c8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit that referenced this pull request Nov 1, 2022
Trying to set the git config for core.longpaths to "true" to enable
long file paths on Windows, as that was blocking us from checking out
OpenSearch-Dashboards.

Signed-off-by: Michael Froh <[email protected]>

Signed-off-by: Michael Froh <[email protected]>
(cherry picked from commit 713c9c8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh pushed a commit that referenced this pull request Nov 1, 2022
Trying to set the git config for core.longpaths to "true" to enable
long file paths on Windows, as that was blocking us from checking out
OpenSearch-Dashboards.

Signed-off-by: Michael Froh <[email protected]>

Signed-off-by: Michael Froh <[email protected]>
(cherry picked from commit 713c9c8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
msfroh added a commit that referenced this pull request Nov 1, 2022
* chore: Update Cypress version

Signed-off-by: Mingkun Ma <[email protected]>

* Initial commit for integration test

Signed-off-by: Mingkun Ma <[email protected]>

* updating backport to 2.0

Signed-off-by: Mark Cohen <[email protected]>

* Moving PULL_REQUEST_TEMPLATE.md to .github dir (#35)

* moving PR template to .github folder

Signed-off-by: Mark Cohen <[email protected]>

* moving PR template to .github folder

Signed-off-by: Mark Cohen <[email protected]>

Signed-off-by: Mark Cohen <[email protected]>

* Add windows-latest back to test-and-build workflow (#39)

Trying to set the git config for core.longpaths to "true" to enable
long file paths on Windows, as that was blocking us from checking out
OpenSearch-Dashboards.

Signed-off-by: Michael Froh <[email protected]>

Signed-off-by: Michael Froh <[email protected]>

* Add codeowner (#43)

Signed-off-by: Peter Zhu <[email protected]>

Signed-off-by: Peter Zhu <[email protected]>

* Make srdash compatible with default build script (#46)

Signed-off-by: Peter Zhu <[email protected]>

Signed-off-by: Peter Zhu <[email protected]>

Signed-off-by: Mingkun Ma <[email protected]>
Signed-off-by: Mark Cohen <[email protected]>
Signed-off-by: Michael Froh <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
Co-authored-by: Mingkun Ma <[email protected]>
Co-authored-by: msfroh <[email protected]>
Co-authored-by: Peter Zhu <[email protected]>
@macohen macohen added the infra Infrastructure/Build/Platform Changes label Nov 3, 2022
macohen pushed a commit to macohen/dashboards-search-relevance that referenced this pull request Nov 3, 2022
…t#39)

Trying to set the git config for core.longpaths to "true" to enable
long file paths on Windows, as that was blocking us from checking out
OpenSearch-Dashboards.

Signed-off-by: Michael Froh <[email protected]>

Signed-off-by: Michael Froh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.4 infra Infrastructure/Build/Platform Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Windows Support
2 participants