Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search bar snapshot according to upstream change #242

Merged

Conversation

derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Sep 5, 2023

Description

update search bar snapshots according to upstream changes
Probably from: opensearch-project/OpenSearch-Dashboards@b24f33a

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@derek-ho derek-ho changed the title update search bar snapshot according to upstream change Update search bar snapshot according to upstream change Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Merging #242 (9709283) into main (935b6d9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #242   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

@derek-ho derek-ho merged commit 5101793 into opensearch-project:main Sep 5, 2023
10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2023
Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 5101793)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
derek-ho added a commit that referenced this pull request Sep 7, 2023
#243)

* update search bar snapshot according to upstream change (#242)

Signed-off-by: Derek Ho <[email protected]>
(cherry picked from commit 5101793)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* point to 2.x

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Derek Ho <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants