Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/CD] Add Cypress e2e workflow for gantt chart #298

Merged
merged 16 commits into from
Dec 14, 2023

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Dec 13, 2023

Description

Add Cypress e2e workflow for gantt chart

Related Issue

Cypress error matches the expected error I captured on: #296

The response we got was:
Status: 406 - Not Acceptable
Headers: {
  "content-type": "application/json; charset=utf-8",
  "osd-name": "fv-az985-504",
  "cache-control": "private, no-cache, no-store, must-revalidate",
  "vary": "accept-encoding",
  "content-encoding": "gzip",
  "date": "Wed, 13 Dec 2023 23:40:25 GMT",
  "connection": "keep-alive",
  "keep-alive": "timeout=120",
  "transfer-encoding": "chunked"
}
Body: {
  "error": "Content-Type header [application/x-www-form-urlencoded] is not supported",
  "status": 406
}

Link: https://github.com/opensearch-project/dashboards-visualizations/actions/runs/7202310509/job/19620185810?pr=298#step:20:115

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e13d24) 94.73% compared to head (d5d3a3c) 94.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   94.73%   94.73%           
=======================================
  Files           5        5           
  Lines         152      152           
  Branches       45       45           
=======================================
  Hits          144      144           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
ps48
ps48 previously approved these changes Dec 13, 2023
@ps48
Copy link
Member

ps48 commented Dec 13, 2023

Let's backport this. During backport we'll have to modify the below lines:

OPENSEARCH_DASHBOARDS_VERSION: 'main'
OPENSEARCH_VERSION: '3.0.0'
OPENSEARCH_PLUGIN_VERSION: '3.0.0.0'

mengweieric
mengweieric previously approved these changes Dec 14, 2023
@RyanL1997 RyanL1997 dismissed stale reviews from mengweieric and ps48 via 087ce8b December 14, 2023 00:09
Copy link
Collaborator

@mengweieric mengweieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooooo

@ps48
Copy link
Member

ps48 commented Dec 14, 2023

cypress is expected to fail for now. Synced with @RyanL1997 offline, he will create a backport for this to 2.x

@ps48 ps48 merged commit 8f0628f into opensearch-project:main Dec 14, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants