Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Feedback on security docs #7367

Closed
4 of 7 tasks
hdhalter opened this issue Jun 11, 2024 · 7 comments
Closed
4 of 7 tasks

[DOC] Feedback on security docs #7367

hdhalter opened this issue Jun 11, 2024 · 7 comments
Assignees
Labels
3 - Done Issue is done/complete Feedback Feedback received from feedback mechanism on doc-website security

Comments

@hdhalter
Copy link
Contributor

hdhalter commented Jun 11, 2024

What do you want to do?

  • Request a change to existing documentation
  • Add new documentation
  • Report a technical problem with the documentation
  • Other

Tell us about your request. Provide a summary of the request and all versions that are affected.
Community feedback on these access control topics:

What other resources are available? Provide links to related issues, POCs, steps for testing, etc.

@hdhalter hdhalter added untriaged security 1 - Backlog - CON Feedback Feedback received from feedback mechanism on doc-website and removed untriaged labels Jun 11, 2024
@leanneeliatra
Copy link
Contributor

@hdhalter can you assign me please.

@leanneeliatra
Copy link
Contributor

I have submitted the PR for 20240131 https://github.com/opensearch-project/documentation-website/pull/7378/files cc @hdhalter and @scrawfor99

@leanneeliatra
Copy link
Contributor

@hdhalter @natebower In our conversation yesterday in relation to
20240215 | /docs/2.9/security/access-control/default-action-groups/ | This page should explicitly say which actions are included in which action group. This is unhelpful for users trying to build custom roles because the actions are not listed.
This has been updated in the recent versions of the documentation and therefore, I think point 2 above (20240215) can be closed.

@hdhalter
Copy link
Contributor Author

@hdhalter @natebower In our conversation yesterday in relation to 20240215 | /docs/2.9/security/access-control/default-action-groups/ | This page should explicitly say which actions are included in which action group. This is unhelpful for users trying to build custom roles because the actions are not listed. This has been updated in the recent versions of the documentation and therefore, I think point 2 above (20240215) can be closed.

You're right. Looks like this was addressed in #6405. (I think you meant to tag @Naarcha-AWS.) Thanks, @leanneeliatra!

@leanneeliatra
Copy link
Contributor

I did indeed thanks @hdhalter

@leanneeliatra
Copy link
Contributor

Hi @AntonEliatra, could you guide/give input on 20240522 please?

@hdhalter hdhalter added 2 - In progress Issue/PR: The issue or PR is in progress. and removed 1 - Backlog - CON labels Jun 14, 2024
AntonEliatra added a commit to AntonEliatra/documentation-website that referenced this issue Jun 17, 2024
Naarcha-AWS added a commit that referenced this issue Jun 25, 2024
* adding explanation to jwks validation #7367 #20240522

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 25, 2024
* adding explanation to jwks validation #7367 #20240522

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit 37e451b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 2 - In progress Issue/PR: The issue or PR is in progress. labels Jun 25, 2024
@hdhalter
Copy link
Contributor Author

All issues have been addressed. Thanks, @leanneeliatra and @AntonEliatra !

leanneeliatra pushed a commit to leanneeliatra/opensearch-documentation-website-forl that referenced this issue Jul 24, 2024
…22 (opensearch-project#7398)

* adding explanation to jwks validation opensearch-project#7367 #20240522

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Done Issue is done/complete Feedback Feedback received from feedback mechanism on doc-website security
Projects
None yet
Development

No branches or pull requests

2 participants