Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding explanation to jwks validation #7367 #20240522 #7398

Merged

Conversation

AntonEliatra
Copy link
Contributor

Description

adding explanation to jwks validation

Issues Resolved

#7367

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Jun 24, 2024
@Naarcha-AWS Naarcha-AWS self-assigned this Jun 25, 2024
@Naarcha-AWS Naarcha-AWS added the backport 2.14 PR: Backport label for 2.14 label Jun 25, 2024
@Naarcha-AWS Naarcha-AWS merged commit 37e451b into opensearch-project:main Jun 25, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 25, 2024
* adding explanation to jwks validation #7367 #20240522

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
(cherry picked from commit 37e451b)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@hdhalter hdhalter mentioned this pull request Jun 25, 2024
7 tasks
@hdhalter hdhalter added 3 - Done Issue is done/complete and removed 4 - Doc review PR: Doc review in progress labels Jun 25, 2024
@Naarcha-AWS Naarcha-AWS added backport 2.15 and removed backport 2.14 PR: Backport label for 2.14 labels Jun 26, 2024
@opensearch-trigger-bot
Copy link

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/backport-2.15
# Create a new branch
git switch --create backport/backport-7398-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 37e451b72d49588b6e081d20c69f588d080e57b7
# Push it to GitHub
git push --set-upstream origin backport/backport-7398-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport/backport-7398-to-2.15.

leanneeliatra pushed a commit to leanneeliatra/opensearch-documentation-website-forl that referenced this pull request Jul 24, 2024
…22 (opensearch-project#7398)

* adding explanation to jwks validation opensearch-project#7367 #20240522

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Signed-off-by: Naarcha-AWS <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Naarcha-AWS <[email protected]>
Co-authored-by: Naarcha-AWS <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants