Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add threat intel source apis for create delete get search operations #7847

Closed
wants to merge 15 commits into from

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Jul 26, 2024

Description

added threat intel source apis for create delete get search operations

Issues Resolved

Closes #7714

Version

2.16

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@eirsep
Copy link
Member Author

eirsep commented Jul 26, 2024

@AWSHurneyt plz review

@hdhalter hdhalter added 3 - Tech review PR: Tech review in progress release-notes PR: Include this PR in the automated release notes labels Jul 26, 2024
"bucket_name": "threat-intel-s3-test-bucket",
"object_key": "alltypess3object",
"region": "us-west-2",
"role_arn": "arn:aws:iam::248279774929:role/threat_intel_s3_test_role"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we instead use a placeholder here like <ROLE_ARN>?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. It's a dummy aws account but will let @Naarcha-AWS and @hdhalter recommned the right practice.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with a dummy account, personally.


# Threat Intelligence Source Configuration APIs

The following APIs can be used for tasks related to threat intelligence source configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eirsep Would it be helpful to define what a source is for our purposes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started off with the APIs
Once that's done, similar to detectors, I will define entities and detail them out in another commit to this PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a page for Threat intel overview plz check

Copy link
Contributor

@hdhalter hdhalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @eirsep! I entered a few suggestion so you can see what we are looking for in a more thorough doc review. Thanks.


# Threat Intelligence Source Configuration APIs

The following APIs can be used for tasks related to threat intelligence source configurations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following APIs can be used for tasks related to threat intelligence source configurations.
You can use threat intelligence source API to configure tasks related to threat intelligence sources.

---
## Create Threat intel source API

Creates a new threat intel source.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Creates a new threat intel source.
The following command creates a new threat intelligence source.

@Naarcha-AWS Naarcha-AWS self-assigned this Jul 27, 2024
@eirsep
Copy link
Member Author

eirsep commented Jul 27, 2024

@AWSHurneyt what documentation should we add related to the S3 Role ARN on what needs to be configured?

@eirsep eirsep marked this pull request as ready for review July 29, 2024 21:21
@hdhalter hdhalter added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Jul 29, 2024
@hdhalter hdhalter changed the title added threat intel source apis for create delete get search operations Add threat intel source apis for create delete get search operations Jul 29, 2024
@hdhalter hdhalter removed their assignment Jul 30, 2024
@eirsep
Copy link
Member Author

eirsep commented Jul 30, 2024

@AWSHurneyt @Naarcha-AWS plz review

eirsep and others added 14 commits August 1, 2024 10:23
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Co-authored-by: Heather Halter <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
@Naarcha-AWS Naarcha-AWS mentioned this pull request Aug 5, 2024
1 task
@Naarcha-AWS
Copy link
Collaborator

Closing in favor of #7905

@Naarcha-AWS Naarcha-AWS closed this Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - Doc review PR: Doc review in progress release-notes PR: Include this PR in the automated release notes v2.16.0
Projects
None yet
5 participants