Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ascii folding token filter #7912

Merged
merged 14 commits into from
Sep 11, 2024
Merged

Add Ascii folding token filter #7912

merged 14 commits into from
Sep 11, 2024

Conversation

AntonEliatra
Copy link
Contributor

Description

Adding Ascii folding token filter

Issues Resolved

Closes #7873

Version

all

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2024

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

@hdhalter hdhalter added 3 - Tech review PR: Tech review in progress analyzers labels Aug 6, 2024
@kolchfa-aws
Copy link
Collaborator

@udabhas Could you review this PR for technical accuracy?

@vagimeli
Copy link
Collaborator

@varun-lodaya The documentation is awaiting tech review and approval, which is delaying progress. Could you please suggest alternative reviewers who can assist with this task in a timely manner? We're eager to move this forward. Thank you.

udabhas
udabhas approved these changes Aug 29, 2024
View reviewed changes
Copy link

@udabhas udabhas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@vagimeli
Copy link
Collaborator

@kolchfa-aws This is tech reviewer approved and ready for doc review at your availability. Thank you.

@vagimeli vagimeli added 4 - Doc review PR: Doc review in progress and removed 3 - Tech review PR: Tech review in progress labels Aug 29, 2024
kolchfa-aws
kolchfa-aws requested changes Aug 29, 2024
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done, @AntonEliatra! Requesting changes to make sure our naming convention is followed.

_analyzers/token-filters/asciifolding.md Outdated
nav_order: 20
---

# ASCIIFolding token filter
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with 2 words everywhere: "ASCII foldidng"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kolchfa-aws thats updated now, thank you for review

_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
@kolchfa-aws kolchfa-aws assigned kolchfa-aws and unassigned vagimeli Aug 29, 2024
AntonEliatra and others added 2 commits September 3, 2024 15:40
@AntonEliatra @kolchfa-aws
Apply suggestions from code review
e773672 
Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
updating as per comments
629ae69 
Signed-off-by: Anton Rubin <[email protected]>
kolchfa-aws
kolchfa-aws approved these changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Moving to editorial review.

@kolchfa-aws kolchfa-aws added 5 - Editorial review PR: Editorial review in progress and removed 4 - Doc review PR: Doc review in progress labels Sep 3, 2024
natebower
natebower reviewed Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonEliatra @kolchfa-aws Please see my comments and changes and let me know if you have any questions. Thanks!

_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
_analyzers/token-filters/asciifolding.md Outdated Show resolved Hide resolved
AntonEliatra and others added 2 commits September 11, 2024 15:21
@AntonEliatra @natebower
Apply suggestions from code review
34d3486 
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
Update asciifolding.md
cc190c2 
Signed-off-by: AntonEliatra <[email protected]>
@AntonEliatra
Copy link
Contributor Author

@natebower Thank you for the review, comments have now been addressed

@kolchfa-aws kolchfa-aws merged commit b41858a into opensearch-project:main Sep 11, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 11, 2024
@github-actions @kolchfa-aws @natebower
Add Ascii folding token filter (#7912)
052c889 
* adding asciifolding token filter page #7873

Signed-off-by: AntonEliatra <[email protected]>

* updating the naming

Signed-off-by: AntonEliatra <[email protected]>

* updating as per PR comments

Signed-off-by: AntonEliatra <[email protected]>

* updating the heading

Signed-off-by: AntonEliatra <[email protected]>

* Updating details as per comments

Signed-off-by: AntonEliatra <[email protected]>

* Updating details as per comments

Signed-off-by: AntonEliatra <[email protected]>

* Updating details as per comments

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* updating as per comments

Signed-off-by: Anton Rubin <[email protected]>

* Apply suggestions from code review

Signed-off-by: kolchfa-aws <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Update asciifolding.md

Signed-off-by: AntonEliatra <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
(cherry picked from commit b41858a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 11, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Sep 11, 2024
@opensearch-trigger-bot
Add Ascii folding token filter (#7912) (#8221)
1dabab6
@AntonEliatra AntonEliatra deleted the ASCIIFolding-token-filter branch September 12, 2024 10:00
epugh pushed a commit to o19s/documentation-website that referenced this pull request Sep 12, 2024
@AntonEliatra @kolchfa-aws
@natebower @epugh
Add Ascii folding token filter (opensearch-project#7912)
dc0103d 
* adding asciifolding token filter page opensearch-project#7873

Signed-off-by: AntonEliatra <[email protected]>

* updating the naming

Signed-off-by: AntonEliatra <[email protected]>

* updating as per PR comments

Signed-off-by: AntonEliatra <[email protected]>

* updating the heading

Signed-off-by: AntonEliatra <[email protected]>

* Updating details as per comments

Signed-off-by: AntonEliatra <[email protected]>

* Updating details as per comments

Signed-off-by: AntonEliatra <[email protected]>

* Updating details as per comments

Signed-off-by: AntonEliatra <[email protected]>

* Apply suggestions from code review

Co-authored-by: kolchfa-aws <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* updating as per comments

Signed-off-by: Anton Rubin <[email protected]>

* Apply suggestions from code review

Signed-off-by: kolchfa-aws <[email protected]>

* Apply suggestions from code review

Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: AntonEliatra <[email protected]>

* Update asciifolding.md

Signed-off-by: AntonEliatra <[email protected]>

---------

Signed-off-by: AntonEliatra <[email protected]>
Signed-off-by: Anton Rubin <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
Co-authored-by: Nathan Bower <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebower natebower natebower left review comments

@udabhas udabhas udabhas approved these changes

@kolchfa-aws kolchfa-aws kolchfa-aws approved these changes

@hdhalter hdhalter Awaiting requested review from hdhalter

@Naarcha-AWS Naarcha-AWS Awaiting requested review from Naarcha-AWS Naarcha-AWS is a code owner

@vagimeli vagimeli Awaiting requested review from vagimeli vagimeli is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@dlvenable dlvenable Awaiting requested review from dlvenable dlvenable is a code owner

@epugh epugh Awaiting requested review from epugh epugh is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

Assignees

@kolchfa-aws kolchfa-aws

Labels
5 - Editorial review PR: Editorial review in progress analyzers backport 2.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] Token filters - asciifolding
6 participants
@AntonEliatra @kolchfa-aws @vagimeli @udabhas @natebower @hdhalter