Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding that comma seperated lists of indices are supported. #8040

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

landon-lengyel
Copy link
Contributor

Signed-off-by: Landon Lengyel [email protected]

Description

The _cluster/health API supports comma separated indices (like most endpoints) but that isn't specified. This resolves that.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

Version

2.16 - Likely all

Frontend features

If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @landon-lengyel! A couple of suggestions to make this adhere with our API template

_api-reference/cluster-api/cluster-health.md Outdated Show resolved Hide resolved
_api-reference/cluster-api/cluster-health.md Outdated Show resolved Hide resolved
_api-reference/cluster-api/cluster-health.md Outdated Show resolved Hide resolved
_api-reference/cluster-api/cluster-health.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws kolchfa-aws merged commit f04aa68 into opensearch-project:main Aug 19, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 19, 2024
* Adding that comma seperated lists of indices are supported.
Signed-off-by: Landon Lengyel <[email protected]>

* Apply suggestions from code review

Signed-off-by: kolchfa-aws <[email protected]>

---------

Signed-off-by: kolchfa-aws <[email protected]>
Co-authored-by: Landon Lengyel <[email protected]>
Co-authored-by: kolchfa-aws <[email protected]>
(cherry picked from commit f04aa68)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants