Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc for adding new param in cat shards action for cancellation… #8127

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

aasom143
Copy link
Contributor

@aasom143 aasom143 commented Aug 29, 2024

… support

Description

Cancellation support on cat shards admin API. Added new flag to set the timeout for shard request.

Issues Resolved

Closes #13908

Version

From OS version 2.17 and onwards, the cancellation support will be given to cat shards API.

Checklist

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and subject to the Developers Certificate of Origin.
    For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged.

Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer.

When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review.

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aasom143! Just one suggestion.

@@ -33,6 +33,7 @@ Parameter | Type | Description
bytes | Byte size | Specify the units for byte size. For example, `7kb` or `6gb`. For more information, see [Supported units]({{site.url}}{{site.baseurl}}/opensearch/units/).
local | Boolean | Whether to return information from the local node only instead of from the cluster manager node. Default is `false`.
cluster_manager_timeout | Time | The amount of time to wait for a connection to the cluster manager node. Default is 30 seconds.
cancel_after_time_interval | Time | The time after which the shards request will be canceled. Default is -1.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cancel_after_time_interval | Time | The time after which the shards request will be canceled. Default is -1.
cancel_after_time_interval | Time | The amount of time after which the shard request will be canceled. Default is `-1`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was referring the flag from the cat search API, Can you please check that - https://opensearch.org/docs/latest/api-reference/search/
If you still want i will make above suggestion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This way it's clearer that it's the amount of time and not just a time on the clock. We should change in search API too.

@kolchfa-aws kolchfa-aws added release-notes PR: Include this PR in the automated release notes v2.17.0 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. labels Aug 29, 2024
@aasom143
Copy link
Contributor Author

aasom143 commented Sep 3, 2024

@kolchfa-aws can you please check and merge if it looks good?

Copy link
Collaborator

@kolchfa-aws kolchfa-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws
Copy link
Collaborator

kolchfa-aws commented Sep 3, 2024

Thank you, @aasom143! Applying "Done but waiting to merge" label to put this in the 2.17 editorial queue starting 9/11. This PR will be merged before the release.

@kolchfa-aws kolchfa-aws added 6 - Done but waiting to merge PR: The work is done and ready to merge 5 - Editorial review PR: Editorial review in progress and removed 1 - Backlog - DEV Developer assigned to issue is responsible for creating PR. labels Sep 3, 2024
Copy link
Collaborator

@natebower natebower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolchfa-aws kolchfa-aws merged commit 5145254 into opensearch-project:main Sep 11, 2024
9 checks passed
epugh pushed a commit to o19s/documentation-website that referenced this pull request Sep 12, 2024
opensearch-project#8127)

* Update doc for adding new param in cat shards action for cancellation support

Signed-off-by: Somesh Gupta <[email protected]>

* Fixed comment

Signed-off-by: Somesh Gupta <[email protected]>

---------

Signed-off-by: Somesh Gupta <[email protected]>
Signed-off-by: Eric Pugh <[email protected]>
noahstaveley pushed a commit to noahstaveley/documentation-website that referenced this pull request Sep 23, 2024
opensearch-project#8127)

* Update doc for adding new param in cat shards action for cancellation support

Signed-off-by: Somesh Gupta <[email protected]>

* Fixed comment

Signed-off-by: Somesh Gupta <[email protected]>

---------

Signed-off-by: Somesh Gupta <[email protected]>
Signed-off-by: Noah Staveley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Editorial review PR: Editorial review in progress 6 - Done but waiting to merge PR: The work is done and ready to merge release-notes PR: Include this PR in the automated release notes v2.17.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants